Drop temporary workaround for get_codec
#361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This workaround was added because `get_codec` was modifying its argument. However as of Numcodecs 0.6.0, `get_codec` does not modify its argument as it takes a copy and modifies the copy instead. Given as we now require Numcodecs 0.6.0, this workaround is no longer needed. Hence we drop it.
This was referenced Dec 10, 2018
|
Should be good to merge I think. Please let me know if you have any concerns, @alimanfoo. |
|
Going ahead and merging this as it doesn't seem controversial (given it is only removing a workaround added after the last release that has already been addressed upstream in Numcodecs). Though if there are any concerns or issues, please let me know and I'd be happy to address them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to PR ( #352 ) and PR ( #268 )
This workaround was added because
get_codecwas modifying its argument. However as of Numcodecs 0.6.0,get_codecdoes not modify its argument as it takes a copy and modifies the copy instead. ( zarr-developers/numcodecs#79 ) Given as we now require Numcodecs 0.6.0, this workaround is no longer needed. Hence we drop it.TODO:
tox -e docs)