Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop 3.6 builds #774

Merged
merged 6 commits into from
Jun 16, 2021
Merged

Drop 3.6 builds #774

merged 6 commits into from
Jun 16, 2021

Conversation

joshmoore
Copy link
Member

see positive vote in #765

TODO:

  • Add unit tests and/or doctests in docstrings
  • Add docstrings and API docs for any new/modified user-facing classes and functions
  • New/modified features documented in docs/tutorial.rst
  • Changes documented in docs/release.rst
  • GitHub Actions have all passed
  • Test coverage is 100% (Codecov passes)

@joshmoore joshmoore changed the title Replace 3.6 builds with 3.9 Drop 3.6 builds Jun 15, 2021
This was referenced Jun 15, 2021
Closed
Merged
jakirkham
jakirkham reviewed Jun 16, 2021
View reviewed changes
requirements_dev_optional.txt Outdated
Comment on lines 19 to 22
s3fs==2021.5.0; python_version > '3.6'
fsspec==2021.5.0; python_version > '3.6'
moto[server]>=1.3.14; python_version > '3.6'
s3fs==2021.5.0; python_version > '3.7'
fsspec==2021.5.0; python_version > '3.7'
moto[server]>=1.3.14; python_version > '3.7'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can just drop python_version. Believe this was just here because these packages didn't exist for Python 3.6

jakirkham
jakirkham reviewed Jun 16, 2021
View reviewed changes
requirements_dev_numpy.txt Outdated
numpy==1.20.3; python_version >= '3.7'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
numpy==1.20.3; python_version >= '3.7'
numpy==1.20.3

jakirkham
jakirkham reviewed Jun 16, 2021
View reviewed changes
Copy link
Member

@jakirkham jakirkham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Josh! 😄 Looks good. Had a couple minor suggestions to simplify things going forward

@joshmoore
Copy link
Member Author

Pushed. Assuming that all goes green, let's get this in since other PRs are now failing due to the missing types-redis dependency. We can decide on when/how to release as a follow on (though my guess is we roll this and any other immediate fixes into a 2.9.0). Want to give it a positive review for posterity?

@jakirkham jakirkham merged commit f6338b7 into zarr-developers:master Jun 16, 2021
@joshmoore
Copy link
Member Author

Thanks, @jakirkham. I'll start getting open PRs green.

@joshmoore joshmoore deleted the droppy36 branch June 16, 2021 19:09
joshmoore added a commit to joshmoore/zarr-python that referenced this pull request Jun 17, 2021
@joshmoore
Drop the additional numpy 1.16 test
7bd70a0 
see:
 * zarr-developers#774 which drops Python 3.6
 * zarr-developers#749 which bumps h5py to 3.2
@joshmoore joshmoore mentioned this pull request Jun 17, 2021
Merged
joshmoore added a commit that referenced this pull request Jun 17, 2021
@joshmoore
Drop the additional numpy 1.16 test (#778)
dd0e779 
* Drop the additional numpy 1.16 test

see:
 * #774 which drops Python 3.6
 * #749 which bumps h5py to 3.2

* Test numpy 1.17 as the 'old' version
@joshmoore joshmoore mentioned this pull request Jun 21, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakirkham jakirkham jakirkham approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joshmoore @jakirkham