Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop the additional numpy 1.16 test #778

Merged
merged 2 commits into from
Jun 17, 2021
Merged

Drop the additional numpy 1.16 test #778

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7bd70a0
Drop the additional numpy 1.16 test
joshmoore Jun 17, 2021
8f204ea
Test numpy 1.17 as the 'old' version
joshmoore Jun 17, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/python-package.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ jobs:
strategy:
matrix:
python-version: [3.7, 3.8]
numpy_version: ['==1.16.4', '']
numpy_version: ['', '==1.17.*']
services:
redis:
image: redis
Expand Down
7 changes: 3 additions & 4 deletions tox.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
# and then run "tox" from this directory.

[tox]
envlist = py37-npy{115,116,latest}, py38, docs
envlist = py37-npy{117,latest}, py38, docs

[testenv]
install_command = pip install --no-binary=numcodecs {opts} {packages}
Expand All @@ -20,7 +20,7 @@ commands =
# main unit test runner
py38: pytest -v --cov=zarr --cov-config=.coveragerc zarr
# don't collect coverage when running older numpy versions
py37-{npy115,npy116}: pytest -v zarr
py37-npy117: pytest -v zarr
# collect coverage and run doctests under py37
py37-npylatest: pytest -v --cov=zarr --cov-config=.coveragerc --doctest-plus zarr --remote-data
# generate a coverage report
Expand All @@ -32,8 +32,7 @@ commands =
# print environment for debugging
pip freeze
deps =
py37-npy115: numpy==1.15.4
py37-npy116: numpy==1.16.4
py37-npy117: numpy==1.17.*
py37-npylatest,py38: -rrequirements_dev_numpy.txt
-rrequirements_dev_minimal.txt
-rrequirements_dev_optional.txt
Expand Down