Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avoid NumPy 1.21.0 due to bug #791

Merged
merged 1 commit into from
Jun 24, 2021

Conversation

grlee77
Copy link
Contributor

@grlee77 grlee77 commented Jun 24, 2021

This PR blocks NumPy 1.21.0 due to numpy/numpy#19325

I cherry-picked this commit from #789 where it resolved the observed segfault

TODO:

  • Add unit tests and/or doctests in docstrings
  • Add docstrings and API docs for any new/modified user-facing classes and functions
  • New/modified features documented in docs/tutorial.rst
  • Changes documented in docs/release.rst
  • GitHub Actions have all passed
  • Test coverage is 100% (Codecov passes)

@joshmoore
Copy link
Member

I think the stuck jobs are due to the fact that the workflow definition changed. I'm merging so that other PRs can be updated to go green. (cc: @grlee77 @clbarnes)

@joshmoore joshmoore merged commit 936b3f5 into zarr-developers:master Jun 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants