Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Core protocol v3.0 development branch #16

Merged
merged 187 commits into from
May 20, 2022
Merged

Conversation

alimanfoo
Copy link
Member

@alimanfoo alimanfoo commented Apr 24, 2019

This PR is intended as a focus for work on version 3.0 of the Zarr core protocol.

To contribute to this PR, please make a PR to the core-protocol-v3.0-dev branch. Please do not push changes directly to the core-protocol-v3.0-dev branch.

Rendering docs from this branch can be viewed on RTFD.

@alimanfoo alimanfoo changed the title WIP: Zarr core protocol version 3.0 WIP: Core protocol version 3.0 Apr 24, 2019
@alimanfoo
Copy link
Member Author

I added PR #17 with some work towards defining a conceptual model.

@alimanfoo alimanfoo changed the title WIP: Core protocol version 3.0 WIP: Core protocol v3.0 Apr 24, 2019
@jakirkham
Copy link
Member

Sorry, I might be missing something here. Does PR ( #17 ) replace this?

…tual-model

Core protocol v3.0 - conceptual model
@alimanfoo
Copy link
Member Author

Sorry, I might be missing something here. Does PR ( #17 ) replace this?

No, sorry, #17 was working adding to this. I.e., #17 was a PR on this PR.

I was thinking that we use this PR and branch (core-protocol-v3.0-dev) as the main development branch for work on the v3.0 core protocol, but that we don't push directly to this branch, rather we make separate PRs against this branch, e.g., to bring in content for a particular section.

@alimanfoo
Copy link
Member Author

I made PR #18 with a straw man for a section on data types, and PR #22 with a straw man for a section on chunk grids.

@alimanfoo alimanfoo changed the title WIP: Core protocol v3.0 WIP: Core protocol v3.0 development branch May 8, 2019
@alimanfoo
Copy link
Member Author

I've added #24 with a straw man for a section on memory layouts.

@alimanfoo
Copy link
Member Author

I've added #25 with a straw man for a section on node names.

@joshmoore joshmoore mentioned this pull request Apr 29, 2022
@joshmoore
Copy link
Member

See open comments on #135

joshmoore and others added 5 commits May 6, 2022 16:39
…-v3.0-dev

As discussed during recent community meetings and steering council,
merging this proposal into the dev branch as a common basis for
discussions. The final list of features to be included in v3.0
is to be decided.
…tensions

Structure spec pages and clarify extension points
@jakirkham
Copy link
Member

I wonder if it would make more sense to merge this at this point as opposed to merging more PRs into this one. Understand there may still be rough edges and things we need to sort out still, but am just thinking about this practically. Please feel free to push back on this suggestion though

@joshmoore @rabernat @alimanfoo, thoughts? 🙂

@joshmoore
Copy link
Member

No objections.

@jbms
Copy link
Contributor

jbms commented May 16, 2022

This is just about renaming the core-protocol-v3.0-dev branch to master, right?

That seems fine since the master branch is currently unused.

However, to avoid confusion it might be helpful to clarify in the "About" that this is about zarr v3 only, not zarr v2.

@joshmoore
Copy link
Member

However, to avoid confusion it might be helpful to clarify in the "About" that this is about zarr v3 only, not zarr v2.

👍 (Could even add a section on v2 with links, etc. to help people along)

Waiting a day or two more for final thoughts then this can go in. readthedocs config will need updating at that same time.

@joshmoore joshmoore force-pushed the core-protocol-v3.0-dev branch from a7aa206 to 4153370 Compare May 20, 2022 13:22
@joshmoore
Copy link
Member

As mentioned. Merging and I'll tidy up the RTD configuration. All future branches should be against the mainline.

@joshmoore joshmoore merged commit 6b66d48 into master May 20, 2022
@joshmoore joshmoore deleted the core-protocol-v3.0-dev branch May 20, 2022 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.