Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace chunk_memory_layout with transpose codec #189

Merged
merged 3 commits into from
Jan 18, 2023
Merged

Replace chunk_memory_layout with transpose codec #189

merged 3 commits into from
Jan 18, 2023

Conversation

jbms
Copy link
Contributor

@jbms jbms commented Nov 30, 2022

No description provided.

@jstriebel jstriebel added the core-protocol-v3.0 Issue relates to the core protocol version 3.0 spec label Dec 1, 2022
@jstriebel jstriebel self-requested a review December 1, 2022 14:30
@jstriebel jstriebel mentioned this pull request Dec 1, 2022
Closed
@jstriebel jstriebel mentioned this pull request Dec 6, 2022
Closed
jstriebel
jstriebel reviewed Dec 12, 2022
View reviewed changes
Copy link
Member

@jstriebel jstriebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @jbms, this mostly LGTM 👍
Please also add short notes to the Comparison with Zarr v2 and Change log sections.

@rabernat rabernat assigned rabernat and unassigned rabernat Dec 15, 2022
@rabernat rabernat self-requested a review December 15, 2022 17:11
jstriebel
jstriebel previously approved these changes Jan 10, 2023
View reviewed changes
Copy link
Member

@jstriebel jstriebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks 👍

@jbms
Copy link
Contributor Author

jbms commented Jan 18, 2023

@jstriebel This needs your review again now that I've resolved the conflict.

@jbms jbms merged commit 6f3a612 into zarr-developers:main Jan 18, 2023
@rabernat
Copy link
Contributor

Sorry I never provided a review on this. FWIW, I finally looked it over and I think it's 👌 . Thanks @jbms and @jstriebel for your work here.

@jbms jbms deleted the transpose-codec branch January 19, 2023 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jstriebel jstriebel jstriebel approved these changes

@rabernat rabernat Awaiting requested review from rabernat

Assignees

@jbms jbms

Labels
core-protocol-v3.0 Issue relates to the core protocol version 3.0 spec
Projects
ZEP1
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jbms @rabernat @jstriebel