Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node name changes #85

Closed
wants to merge 4 commits into from
Closed

Conversation

alimanfoo
Copy link
Member

@alimanfoo alimanfoo commented Jul 15, 2020

Following on from discussion on the community call today, this PR proposed two changes regarding the specification of node names:

  • The spec now requires that stores are case sensitive. E.g., the operations set('foo', a) and set('FOO', b) will result in two distinct (key, value) pairs being stored. Subsequently get('foo') will return a and get('FOO') will return b.

  • A note has been added stating our desire to support Unicode in node names and linking to the appropriate issue for comment.

xref #56, #57

@alimanfoo
Copy link
Member Author

cc @Carreau

@jakirkham
Copy link
Member

I think this came up on a previous call. On macOS, the filesystem is case insensitive by default (and this is the common case in the wild). Unfortunately changing a filesystem to be case sensitive is non-trivial as it requires reformatting. Also it may cause breakage in applications that have already assumed things are not case sensitive.

In practice, if neither FOO or foo existed and one of them was created, casing would match the one created (say FOO). However there would not be an option to create both as they would resolve to the same file or directory.

@jakirkham
Copy link
Member

Should add I'm not saying we should make the choice based on macOS's behavior, which is admittedly odd. Just noting this will be a stumbling block for a potentially large set of users. Perhaps we can recommend users avoid creating a path that would conflict on case insensitive storage mediums? Though leave this in users hands.

@Carreau
Copy link
Contributor

Carreau commented Oct 12, 2020

Closed in favor of #97 which is rebased to solve conflicts, but has the same content.

@Carreau Carreau closed this Oct 12, 2020
alimanfoo added a commit that referenced this pull request Oct 16, 2020
* Node name changes

* added clarification about case sensitivity

* fix idiocy

* minor

* update copyright

* Update docs/protocol/core/v3.0.rst

Co-authored-by: Alistair Miles <alimanfoo@googlemail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants