Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update ZEP 1 to reflect the spec changes #33

Merged
merged 6 commits into from
Mar 4, 2023

Conversation

jstriebel
Copy link
Member

@jstriebel jstriebel commented Feb 23, 2023

This updates the ZEP 1 to reflect the motivation and changes of the current v3 spec:
https://zarr-specs.readthedocs.io/en/latest/v3/core/v3.0.html

Also contains a minor update to ZEP 2.

Fixes #32.

@jstriebel
Copy link
Member Author

@jbms It would be great if you could review this as well, just can't assign you as a reviewer myself on github.

draft/ZEP0001.md Outdated Show resolved Hide resolved
@jstriebel jstriebel requested a review from jbms February 27, 2023 09:11
draft/ZEP0001.md Outdated Show resolved Hide resolved
@jstriebel jstriebel requested a review from jbms March 2, 2023 16:56
@jstriebel
Copy link
Member Author

@MSanKeys963 This PR is ready to be merged. I'll add a small follow-up PR for the storage-transformer changes, but those should be a separate PR.

draft/ZEP0001.md Outdated Show resolved Hide resolved
draft/ZEP0001.md Outdated Show resolved Hide resolved
@sanketverma1704
Copy link
Member

Thanks for the work here, @jstriebel and @jbms.
I've reviewed the PR and it looks good. Just added a minor edit above.

Co-authored-by: Sanket Verma <svsanketverma5@gmail.com>
@sanketverma1704 sanketverma1704 merged commit d3ee622 into zarr-developers:main Mar 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Update ZEP1 according to current spec
3 participants