-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update ZEP 1 to reflect the spec changes #33
Merged
sanketverma1704
merged 6 commits into
zarr-developers:main
from
scalableminds:update-zep1
Mar 4, 2023
Merged
update ZEP 1 to reflect the spec changes #33
sanketverma1704
merged 6 commits into
zarr-developers:main
from
scalableminds:update-zep1
Mar 4, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@jbms It would be great if you could review this as well, just can't assign you as a reviewer myself on github. |
jbms
reviewed
Feb 24, 2023
jbms
reviewed
Feb 27, 2023
jbms
approved these changes
Mar 2, 2023
@MSanKeys963 This PR is ready to be merged. I'll add a small follow-up PR for the storage-transformer changes, but those should be a separate PR. |
Thanks for the work here, @jstriebel and @jbms. |
Co-authored-by: Sanket Verma <svsanketverma5@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the ZEP 1 to reflect the motivation and changes of the current v3 spec:
https://zarr-specs.readthedocs.io/en/latest/v3/core/v3.0.html
Also contains a minor update to ZEP 2.
Fixes #32.