Skip to content

Instantiate Rust containers from Python #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Dec 14, 2024
Merged

Instantiate Rust containers from Python #72

merged 14 commits into from
Dec 14, 2024

Conversation

flying-sheep
Copy link
Collaborator

@flying-sheep flying-sheep commented Dec 13, 2024 •
edited
Loading

OK, I think I’m mostly there!

I don’t know where I made an error, could you maybe take a look @LDeakin?

TODO:

  • Maybe we need to improve performance of Basic: It currently contains a StoreConfig, and on each access locks the hashmap. We should probably keep the previous behavior of having Arcs in there which is probably faster

@flying-sheep flying-sheep changed the title Make Raw into class Instantiate Rust containers from Python Dec 13, 2024
@flying-sheep flying-sheep requested a review from LDeakin December 13, 2024 14:54
@flying-sheep flying-sheep linked an issue Dec 13, 2024 that may be closed by this pull request
Don't Use Tuples for Crossing The Python-Rust Language Barrier #71
Closed
@LDeakin LDeakin mentioned this pull request Dec 13, 2024
Merged
LDeakin
LDeakin approved these changes Dec 13, 2024
View reviewed changes
Copy link
Member

@LDeakin LDeakin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much cleaner! Performance seems to be unchanged.

@flying-sheep flying-sheep merged commit 223c57d into ld/http_store Dec 14, 2024
17 checks passed
@flying-sheep flying-sheep deleted the pa/classy branch December 14, 2024 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LDeakin LDeakin LDeakin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Don't Use Tuples for Crossing The Python-Rust Language Barrier
2 participants
@flying-sheep @LDeakin