Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove quickfix for Lizard issue 66 #245

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Remove quickfix for Lizard issue 66 #245

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions field_friend/hardware/status_control.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,6 @@ def __init__(self, robot_brain: RobotBrain, *,
lizard_code = remove_indentation(f'''
rdyp_status = Input({rdyp_pin})
vdp_status = {expander.name + "."}Input({vdp_pin})
# TODO: remove when lizard issue 66 is fixed.
vdp_status.level = 0
vdp_status.active = false
''')
core_message_fields = [
'rdyp_status.level',
Expand Down
15 changes: 0 additions & 15 deletions field_friend/hardware/tornado.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,21 +159,6 @@ def __init__(self, robot_brain: rosys.hardware.RobotBrain, *,
{name}_ref_knife_stop.inverted = false
{name}_ref_knife_ground = {expander.name + "." if (end_stops_on_expander or ref_knife_ground_pin_expander) and expander else ""}Input({ref_knife_ground_pin})
{name}_ref_knife_ground.inverted = true

# TODO: remove when lizard issue 66 is fixed.
{name}_end_top.level = 0
{name}_end_top.active = false
{name}_end_bottom.level = 0
{name}_end_bottom.active = false
{name}_ref_motor.level = 0
{name}_ref_motor.active = false
{name}_ref_gear.level = 0
{name}_ref_gear.active = false
{name}_ref_knife_stop.level = 0
{name}_ref_knife_stop.active = false
{name}_ref_knife_ground.level = 0
{name}_ref_knife_ground.active = false

{name}_z = {expander.name + "." if motors_on_expander and expander else ""}MotorAxis({name}_motor_z, {name + "_end_bottom" if is_z_reversed else name + "_end_top"}, {name + "_end_top" if is_z_reversed else name + "_end_bottom"})

bool {name}_is_referencing = false
Expand Down
5 changes: 0 additions & 5 deletions field_friend/hardware/y_axis_canopen_hardware.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,11 +36,6 @@ def __init__(self, robot_brain: rosys.hardware.RobotBrain, *,
{name}_end_l.inverted = {str(end_stops_inverted).lower()}
{name}_end_r = {expander.name + "." if end_stops_on_expander and expander else ""}Input({end_r_pin})
{name}_end_r.inverted = {str(end_stops_inverted).lower()}
# TODO: remove when lizard issue 66 is fixed.
{name}_end_l.level = 0
{name}_end_l.active = false
{name}_end_r.level = 0
{name}_end_r.active = false
{name} = {expander.name + "." if motor_on_expander and expander else ""}MotorAxis({name}_motor, {name + "_end_l" if reversed_direction else name + "_end_r"}, {name + "_end_r" if reversed_direction else name + "_end_l"})
''')
core_message_fields = [
Expand Down
7 changes: 0 additions & 7 deletions field_friend/hardware/y_axis_stepper_hardware.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,13 +39,6 @@ def __init__(self, robot_brain: rosys.hardware.RobotBrain, *,
{name}_end_l.inverted = {str(end_stops_inverted).lower()}
{name}_end_r = {expander.name + "." if end_stops_on_expander and expander else ""}Input({end_r_pin})
{name}_end_r.inverted = {str(end_stops_inverted).lower()}
# TODO: remove when lizard issue 66 is fixed.
{name}_alarm.level = 0
{name}_alarm.active = false
{name}_end_l.level = 0
{name}_end_l.active = false
{name}_end_r.level = 0
{name}_end_r.active = false
{name} = {expander.name + "." if motor_on_expander and expander else ""}MotorAxis({name}_motor, {name + "_end_l" if reversed_direction else name + "_end_r"}, {name + "_end_r" if reversed_direction else name + "_end_l"})
''')
core_message_fields = [
Expand Down
5 changes: 0 additions & 5 deletions field_friend/hardware/z_axis_canopen_hardware.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,11 +35,6 @@ def __init__(self, robot_brain: rosys.hardware.RobotBrain, *,
{name}_end_t.inverted = {str(end_stops_inverted).lower()}
{name}_end_b = {expander.name + "." if end_stops_on_expander and expander else ""}Input({end_b_pin})
{name}_end_b.inverted = {str(end_stops_inverted).lower()}
# TODO: remove when lizard issue 66 is fixed.
{name}_end_t.level = 0
{name}_end_t.active = false
{name}_end_b.level = 0
{name}_end_b.active = false
{name} = {expander.name + "." if motor_on_expander and expander else ""}MotorAxis({name}_motor, {name + "_end_t" if reversed_direction else name + "_end_b"}, {name + "_end_b" if reversed_direction else name + "_end_t"})
''')
core_message_fields = [
Expand Down
5 changes: 0 additions & 5 deletions field_friend/hardware/z_axis_stepper_hardware.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,11 +38,6 @@ def __init__(self, robot_brain: rosys.hardware.RobotBrain, *,
{name}_end_t.inverted = {str(end_stops_inverted).lower()}
{name}_end_b = {expander.name + "." if end_stops_on_expander and expander else ""}Input({end_b_pin})
{name}_end_b.inverted = {str(end_stops_inverted).lower()}
# TODO: remove when lizard issue 66 is fixed.
{name}_end_t.level = 0
{name}_end_t.active = false
{name}_end_b.level = 0
{name}_end_b.active = false
{name} = {expander.name + "." if motor_on_expander and expander else ""}MotorAxis({name}_motor, {name + "_end_t" if reversed_direction else name + "_end_b"}, {name + "_end_b" if reversed_direction else name + "_end_t"})
''')
core_message_fields = [
Expand Down
Loading