Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Property assignment fix #109

Merged
merged 1 commit into from
Dec 3, 2024
Merged

Property assignment fix #109

merged 1 commit into from
Dec 3, 2024

Conversation

JensOgorek
Copy link
Contributor

@JensOgorek JensOgorek commented Dec 3, 2024

This fixes the creation of properties. They were all linking to the same property. The examples show the same lizard startup script

Before (just changed the input of the last added pin):

core 3913755 0 false 0 false 0 false 0 false 0 false 0 false 
core 3913765 1 true 1 true 1 true 1 true 1 true 1 true

Now (again, changing the last added pin):
The first line looks different, since it is now configured correctly.

core 290031 1 true 1 true 1 false 0 false 1 true 1 true
core 290021 1 true 1 true 1 false 1 true 1 true 1 true

@JensOgorek JensOgorek added the bug Something isn't working label Dec 3, 2024
@JensOgorek JensOgorek added this to the 0.6.1 milestone Dec 3, 2024
@JensOgorek JensOgorek self-assigned this Dec 3, 2024
Copy link
Collaborator

@falkoschindler falkoschindler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, what a bug! Now the code is (hopefully) correct - and cleaner. 🙂
Fingers crossed that we don't need to touch all these 52 files once again for a while...

@JensOgorek
Copy link
Contributor Author

Oh, what a bug! Now the code is (hopefully) correct - and cleaner. 🙂 Fingers crossed that we don't need to touch all these 52 files once again for a while...

My tests say no, but you never know :D

@falkoschindler falkoschindler merged commit 7224f72 into main Dec 3, 2024
@falkoschindler falkoschindler deleted the property_assignment_fix branch December 3, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants