Check relevant pins for p0.flash() #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JensOgorek
changed the title
falkoschindler
approved these changes
Nov 15, 2024
There was a problem hiding this comment.
@JensOgorek I reviewed and simplified the code a bit. This avoids code duplication for message handling. And I think we can simply use strstr twice instead of reading and comparing the int level. Maybe you can have a look and check if it does work as expected.
|
I tested it, it worked like before. |
falkoschindler
approved these changes
Nov 15, 2024
JensOgorek
added a commit
that referenced
this pull request
Nov 19, 2024
* Check relevant pins for p0.flash() (#95) * update: check relevant pins for bootloader * code review and simplification * update: added forceing flash, added disconnect before flashing * review --------- Co-authored-by: Falko Schindler <falko@zauberzeug.com> * add venv to ignores * Expander watchdog for documentation (#98) * updated docs * review --------- Co-authored-by: Falko Schindler <falko@zauberzeug.com> * auto-format BNO055 class --------- Co-authored-by: Falko Schindler <falko@zauberzeug.com> Co-authored-by: Pascal Schade <pascal@zauberzeug.com>
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is for #75
Before flashing, the p0.flash() call will set the GPIO0 to the correct state and check GPIO2 and GPIO12 on the p0 for their states.
GPIO0 and 2 are responsible for booting to the bootloader upon restart.
GPIO12 on low sets the flash voltage to 3.3V. On high, which sets it to 1.8V, it can cause issues when flashing.
The strapping register itself does not need to be checked in that stage of flashing. Since the configuration after the restart would be the relevant one, but then the p0 would be in bootloader mode, which we would not have to check and could not check.