Find IP addresses more robustly using netifaces #1137
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running NiceGUI with
host='0.0.0.0'
(the default) on Ubuntu revealed an issue with finding all IP addresses of the machine. The following welcome message didn't always contain the 192.168.x.x address:This PR resolves this issue using the netifaces package instead of socket. It introduces another dependency, but it's a small one.