Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Highcharts dependency #1863

Merged
merged 6 commits into from
Oct 23, 2023
Merged

Remove Highcharts dependency #1863

merged 6 commits into from
Oct 23, 2023

Conversation

falkoschindler
Copy link
Contributor

@falkoschindler falkoschindler commented Oct 23, 2023 •
edited
Loading

This PR removed the Highcharts dependency. The ui.chart element is now called ui.highchart and requires nicegui-highcharts to be installed.

Open tasks:

  • add nicegui[highcharts] to pyproject.toml
  • release nicegui-highcharts
  • update poetry lock
  • tests green?

@falkoschindler falkoschindler added this to the 1.4 milestone Oct 23, 2023
@falkoschindler falkoschindler linked an issue Oct 23, 2023 that may be closed by this pull request
Providing Highcharts lib with NiceGUI requires commercial products to buy a license #1850
Closed
@falkoschindler falkoschindler marked this pull request as draft October 23, 2023 14:57
@falkoschindler falkoschindler marked this pull request as ready for review October 23, 2023 15:00
@falkoschindler
Copy link
Contributor Author

falkoschindler commented Oct 23, 2023 •
edited
Loading

Ok, looks like

  • we need to release nicegui-highcharts first,
  • then we can update poetry.lock in order to get the tests green,
  • then we can merge this PR.

@falkoschindler falkoschindler merged commit 88ddf3f into main Oct 23, 2023
@falkoschindler falkoschindler deleted the remove-highcharts branch October 23, 2023 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rodja rodja rodja approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.4
Development

Successfully merging this pull request may close these issues.

Providing Highcharts lib with NiceGUI requires commercial products to buy a license
2 participants
@falkoschindler @rodja