Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add demos for using ui.refreshable with local scope #3279

Merged
merged 3 commits into from
Jun 27, 2024
Merged

Add demos for using ui.refreshable with local scope #3279

merged 3 commits into from
Jun 27, 2024

Conversation

falkoschindler
Copy link
Contributor

Inspired by #2535 and #3233, this PR adds 4 demos showing how to use ui.refreshable with different scope.

@falkoschindler falkoschindler requested a review from rodja June 24, 2024 16:56
@falkoschindler falkoschindler added the documentation Improvements or additions to documentation label Jun 24, 2024
@falkoschindler falkoschindler added this to the 1.4.28 milestone Jun 24, 2024
@falkoschindler
Copy link
Contributor Author

@rodja I simplified the demos by removing the ui.input element with access to the user storage and showing the current time instead.

rodja
rodja requested changes Jun 27, 2024
View reviewed changes
Copy link
Member

@rodja rodja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The demos are great. But maybe we should use "Local scope variant A", "Local scope variant B" etc as headlines instead of "Local Scope (1/3)". The latter may change if we add another example which would break any hyperlinks.

@falkoschindler falkoschindler requested a review from rodja June 27, 2024 05:25
@rodja rodja merged commit ffba330 into main Jun 27, 2024
6 checks passed
@rodja rodja deleted the local-refreshable branch June 27, 2024 05:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rodja rodja rodja approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
1.4.28
Development

Successfully merging this pull request may close these issues.
2 participants
@falkoschindler @rodja