Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/web platform version #2

Merged
merged 7 commits into from
Nov 17, 2023
Merged

Feature/web platform version #2

merged 7 commits into from
Nov 17, 2023

Conversation

RodrigoTomeES
Copy link
Contributor

@RodrigoTomeES RodrigoTomeES commented Nov 17, 2023 •
edited
Loading

fix #1

@RodrigoTomeES
refactor: reimplemented with webcryto
655d127 
BREAKING CHANGE: now deterministicHash is async function and renamed algorithms to match webcryto API
@RodrigoTomeES
chore: bumped version from 1.3.1 to 2.0.0
1697fd7
@RodrigoTomeES RodrigoTomeES marked this pull request as draft November 17, 2023 20:41
@RodrigoTomeES RodrigoTomeES mentioned this pull request Nov 17, 2023
Open
@RodrigoTomeES RodrigoTomeES marked this pull request as ready for review November 17, 2023 22:04
@RodrigoTomeES
Copy link
Contributor Author

@zbauman3 can you review it?

@zbauman3
Copy link
Owner

zbauman3 commented Nov 17, 2023 •
edited
Loading

@RodrigoTomeES sure thing, give me an hour or so and I'll take a look

@RodrigoTomeES
Copy link
Contributor Author

@zbauman3 great, thanks!

zbauman3
zbauman3 approved these changes Nov 17, 2023
View reviewed changes
Copy link
Owner

@zbauman3 zbauman3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! This LGTM.

I'll merge, but it's been a while since I released so that might take a bit. It looks like I have a few outdated dependencies too. I'll try to update those and do a release this weekend.

Thanks for the contribution!

@zbauman3 zbauman3 merged commit 8b415c9 into zbauman3:main Nov 17, 2023
@zbauman3
Copy link
Owner

@RodrigoTomeES That ended up being easier to publish than I thought. I accidentally didn't exclude the new .github directory initially, so I re-released as 2.0.1 without it.

Thanks again!

@RodrigoTomeES
Copy link
Contributor Author

@zbauman3 nothing, you are welcome. Thanks for your quick review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zbauman3 zbauman3 zbauman3 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support Cloudflare workers (or any other worker)
2 participants
@RodrigoTomeES @zbauman3