Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement @react-native-community/viewpager #166

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

mgonzalezs
Copy link

No description provided.

maugonsal and others added 3 commits June 13, 2019 23:59
FCBH-123 Implement @react-native-community/viewpager
Copy link

@ahanriat ahanriat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@VinceBT
Copy link

VinceBT commented Jun 27, 2019

@zbtang merge this in a new major version please

@shercoder
Copy link

@zbtang would love to get this merged so people can start using this as soon as possible and before RN marks ViewPagerAndroid obsolete from their repo. 🙏

@shercoder
Copy link

@mgonzalezs At Build.com, we have forked this lib so we can update it to use the RNCViewPager. Would you like to submit this PR to https://github.com/buildcom/React-Native-ViewPager and I can get it merged.

@mgonzalezs
Copy link
Author

@shercoder done! ;)

@shercoder
Copy link

@shercoder done! ;)

@mgonzalezs Thank you so much. I have merged it and released a new tag v2.0.0 https://github.com/buildcom/React-Native-ViewPager/releases/tag/2.0.0

Feel free to use it :)

@Alarees
Copy link

Alarees commented Aug 6, 2019

@shercoder a'm new to git how to use this tag
i have download the 'zip' file and in demo the 'rn-viewpager' version is '^1.2.4', it's old
how to use this Implementation ?

@shercoder
Copy link

@Alarees Please use forked version of this lib here https://github.com/buildcom/React-Native-ViewPager

In your package.json, add this under dependencies:
"rn-viewpager": "github:buildcom/React-Native-ViewPager#2.0.0"
and then run npm install

Then follow the rest of the instructions from the README to integrate it into your project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants