climbing: Photo has its URL #259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
jvaclavik
force-pushed
the
climbing-photo-has-url
branch
from
f59b50b to
c1d87fe
Compare
jvaclavik
force-pushed
the
climbing-photo-has-url
branch
from
c1d87fe to
aef8de0
Compare
zbycz
reviewed
Apr 23, 2024
| @@ -80,7 +87,7 @@ export const ClimbingDialogHeader = ({ onClose }) => { | |||
| <PhotoLinks> | |||
| {photoPaths.map((photo, index) => ( | |||
| <PhotoLink | |||
| onClick={() => onPhotoChange(photo)} | |||
| onClick={() => onPhotoChange(photo, index)} | |||
There was a problem hiding this comment.
Could you use real link a with href? I think it is better to use links if possible, as user can cmd+click it etc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.