SearchBox: Fix broken flyTo on mobile #574
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| (setPreview: (feature: unknown) => void) => (_: never, option: Option) => { | ||
| (setPreview: (feature: unknown) => void) => | ||
| (_: never, option: Option, reason: AutocompleteHighlightChangeReason) => { | ||
| if (reason === 'touch') return; |
There was a problem hiding this comment.
Can you please explain what was the issue here? I know it sometimes needed a double click, though I don't understand why this should help. (Though it helps! 🎉 😃 )
There was a problem hiding this comment.
The first click on the option runs the highlight callback. The second clicks then ran the actual click listener.
Actually I also don't fully understand why instantly returning fixes this issue 😅 but it does and now we just return when the click was from a touch device.
There was a problem hiding this comment.
I see.. on click is like a hover on mobile. That makes sense! THX
instantly returning fixes the issue
That almost looks like some mobile magic.. 😅 aka "if callback takes shorter than something, lets skip it .. apple is known for that 🙃
Description
Reported in #523