fix nil check

zc2638 · Mar 30, 2024 · b8eb09d · b8eb09d
1 parent 92f8c04
commit b8eb09d
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/core/worker/hooks/docker/convert.go b/core/worker/hooks/docker/convert.go
@@ -71,9 +71,10 @@ func toHostConfig(spec *worker.Workflow, step *worker.Step) *container.HostConfi
 			Type: "json-file",
 		},
 	}
-	// windows do not support privileged, so we hard-code
-	// this value to false.
-	if spec.Worker != nil && spec.Worker.Platform.OS == "windows" {
+
+	// windows do not support privileged,
+	// so we hard-code this value to false.
+	if spec.Worker != nil && spec.Worker.Platform != nil && spec.Worker.Platform.OS == "windows" {
 		config.Privileged = false
 	}
 	if len(step.Network) > 0 {

diff --git a/core/worker/worker.go b/core/worker/worker.go
@@ -214,7 +214,7 @@ func execute(
 
 	secretValueSet := sets.New[string]()
 	for _, secret := range secrets {
-		if err := secret.Decrypt(); err == nil {
+		if err := secret.Decrypt(); err != nil {
 			status.Phase = v1.PhaseFailed
 			status.Error = err.Error()
 			for _, step := range status.Steps {