update bip0039 #1261
Closed
update bip0039 #1261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
str4d
requested changes
Mar 12, 2024
| @@ -64,7 +64,7 @@ hdwallet = { workspace = true, optional = true } | |||
| secp256k1 = { workspace = true, optional = true } | |||
|
|
|||
| # - ZIP 339 | |||
| bip0039 = { version = "0.10", features = ["std", "all-languages"] } | |||
| bip0039 = { version = "0.12", features = ["std", "all-languages"] } | |||
There was a problem hiding this comment.
We attempted to upgrade from bip0039 0.10 in #808, but had to downgrade in #812 because the change in bip0039 0.11 to use generics resulted in me spending several hours fighting and losing to the C++ template system in zcashd. While zcashd depends on bip0039 0.10 via zcash_primitives::zip339, we will not be upgrading this dependency. (If someone else wants to fight the C++ template system to enable this, let me know!)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/koushiro/rust-bips/blob/master/bip0039/CHANGELOG.md#version-0110-2022-11-22
https://github.com/koushiro/rust-bips/blob/master/bip0039/CHANGELOG.md#version-0120-2024-02-19
bip0039 has been updated twice since the version was set for librustzcash.
zingolib has dependencies that require the newer version of bip0039