Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make nu6 rust feature stable #1454

Merged
merged 4 commits into from
Aug 5, 2024
Merged

Make nu6 rust feature stable #1454

merged 4 commits into from
Aug 5, 2024

Conversation

oxarbitrage
Copy link
Contributor

@oxarbitrage oxarbitrage commented Jul 23, 2024

We want to add the testnet network activation to Zebra but we need the same in zcash_primitives. We also need to remove the zcash_unstable = "nu6" feature.

@oxarbitrage oxarbitrage marked this pull request as draft July 23, 2024 23:10
Copy link

codecov bot commented Jul 23, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 60.56%. Comparing base (104c0c2) to head (cd56afc).
Report is 2 commits behind head on main.

Files Patch % Lines
components/zcash_protocol/src/consensus.rs 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1454      +/-   ##
==========================================
- Coverage   60.76%   60.56%   -0.21%     
==========================================
  Files         138      139       +1     
  Lines       16313    16372      +59     
==========================================
+ Hits         9912     9915       +3     
- Misses       6401     6457      +56     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@oxarbitrage
Copy link
Contributor Author

  • Need to remove Testnet height and leave it to None for now.

@oxarbitrage oxarbitrage changed the title Make nu6 stable, add testnet activation height and needed constants Make nu6 stable Jul 25, 2024
Copy link
Contributor

@daira daira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@oxarbitrage oxarbitrage changed the title Make nu6 stable Make nu6 rust stable Aug 1, 2024
@oxarbitrage oxarbitrage changed the title Make nu6 rust stable Make nu6 rust feature stable Aug 1, 2024
@oxarbitrage oxarbitrage marked this pull request as ready for review August 1, 2024 15:42
Copy link
Contributor

@str4d str4d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK. Changelog was not updated, but I can do that in a separate PR.

@str4d str4d merged commit 5a4a3e0 into zcash:main Aug 5, 2024
25 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants