Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document the change to v_tx_outputs in zcash_client_sqlite 0.11.0 #1547

Merged
merged 1 commit into from
Sep 23, 2024

Conversation

str4d
Copy link
Contributor

@str4d str4d commented Sep 23, 2024

Closes #1525.

@str4d str4d changed the title Document the change to v_tx_outputs in 0.11.0 Document the change to v_tx_outputs in zcash_client_sqlite 0.11.0 Sep 23, 2024
Copy link

codecov bot commented Sep 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.32%. Comparing base (778fe2e) to head (0936abd).
Report is 8 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1547   +/-   ##
=======================================
  Coverage   61.32%   61.32%           
=======================================
  Files         147      147           
  Lines       18667    18667           
=======================================
+ Hits        11447    11448    +1     
+ Misses       7220     7219    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@nuttycom nuttycom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doc-only ACK

@str4d str4d merged commit d8db481 into main Sep 23, 2024
28 checks passed
@str4d str4d deleted the 1525-document-v_tx_outputs-change branch September 23, 2024 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New sqlite release has undocumented breaking change: v_tx_outputs.to_address is NULL for transparent inputs
2 participants