Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zcash_client_backend: Generalize & extend wallet metadata query API #1580

Merged
merged 2 commits into from
Nov 13, 2024
Merged

zcash_client_backend: Generalize & extend wallet metadata query API #1580

merged 2 commits into from
Nov 13, 2024

Conversation

nuttycom
Copy link
Contributor

No description provided.

@nuttycom nuttycom force-pushed the wallet/multi_output_dynamic_min_split branch 3 times, most recently from 98093e1 to 9ca4f50 Compare October 21, 2024 15:52
@nuttycom nuttycom force-pushed the wallet/multi_output_dynamic_min_split branch 2 times, most recently from cb12eb7 to 3fe1cdb Compare October 25, 2024 15:50
@nuttycom nuttycom marked this pull request as ready for review October 25, 2024 21:45
str4d

This comment was marked as outdated.

Sign in to view

@nuttycom nuttycom dismissed str4d’s stale review October 25, 2024 22:29

This was a test.

@nuttycom nuttycom marked this pull request as draft October 26, 2024 22:53
@nuttycom nuttycom force-pushed the wallet/multi_output_dynamic_min_split branch 2 times, most recently from 37f993e to 600b5e6 Compare November 1, 2024 17:48
@nuttycom nuttycom changed the title Wallet/multi output dynamic min split zcash_client_backend: Generalize & extend wallet metadata query API Nov 1, 2024
@nuttycom nuttycom marked this pull request as ready for review November 1, 2024 17:49
@codecov Codecov
Copy link

codecov bot commented Nov 1, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 69.68504% with 77 lines in your changes missing coverage. Please review.

Project coverage is 56.38%. Comparing base (8b49ca8) to head (00cafa3).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
zcash_client_backend/src/data_api/testing/pool.rs 62.50% 21 Missing ⚠️
zcash_client_backend/src/data_api.rs 60.00% 20 Missing ⚠️
zcash_client_sqlite/src/wallet/common.rs 77.92% 17 Missing ⚠️
zcash_client_backend/src/fees.rs 66.66% 9 Missing ⚠️
zcash_client_sqlite/src/lib.rs 33.33% 6 Missing ⚠️
zcash_client_backend/src/fees/common.rs 71.42% 2 Missing ⚠️
zcash_client_backend/src/data_api/testing.rs 94.44% 1 Missing ⚠️
zcash_client_sqlite/src/error.rs 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1580      +/-   ##
==========================================
+ Coverage   56.30%   56.38%   +0.07%     
==========================================
  Files         148      148              
  Lines       19062    19232     +170     
==========================================
+ Hits        10733    10844     +111     
- Misses       8329     8388      +59

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@daira daira mentioned this pull request Nov 2, 2024
Merged
@nuttycom nuttycom force-pushed the wallet/multi_output_dynamic_min_split branch 3 times, most recently from e9ad4a6 to 530d06b Compare November 12, 2024 21:47
str4d
str4d requested changes Nov 13, 2024
View reviewed changes
Copy link
Contributor

@str4d str4d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 530d06b

components/zcash_protocol/src/value.rs Show resolved Hide resolved
components/zcash_protocol/src/value.rs Show resolved Hide resolved
zcash_client_backend/src/data_api.rs Show resolved Hide resolved
zcash_client_backend/src/data_api.rs Outdated Show resolved Hide resolved
zcash_client_backend/src/data_api.rs Show resolved Hide resolved
zcash_client_sqlite/src/wallet/common.rs Show resolved Hide resolved
zcash_client_backend/src/data_api.rs Show resolved Hide resolved
zcash_client_backend/src/data_api.rs Outdated Show resolved Hide resolved
zcash_client_backend/src/data_api.rs Outdated Show resolved Hide resolved
zcash_client_sqlite/src/wallet/common.rs Outdated Show resolved Hide resolved
@nuttycom nuttycom force-pushed the wallet/multi_output_dynamic_min_split branch from 530d06b to 8c95260 Compare November 13, 2024 18:16
@nuttycom nuttycom mentioned this pull request Nov 13, 2024
Open
@nuttycom nuttycom requested a review from str4d November 13, 2024 18:26
@nuttycom
zcash_client_backend: Generalize & extend account metadata query API
3352671 
This generalizes the previous account metadata query API to be able to
represent more complex queries, and also to return note totals in
addition to note counts.
@nuttycom nuttycom force-pushed the wallet/multi_output_dynamic_min_split branch from 7dab03a to 3352671 Compare November 13, 2024 20:22
@nuttycom
Copy link
Contributor Author

force-pushed to address comments from code review.

str4d
str4d previously approved these changes Nov 13, 2024
View reviewed changes
Copy link
Contributor

@str4d str4d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 3352671 after minor comments, Clippy lints, and rustfmt errors are fixed.

zcash_client_backend/src/fees.rs Outdated Show resolved Hide resolved
zcash_client_sqlite/CHANGELOG.md Outdated Show resolved Hide resolved
zcash_client_sqlite/src/error.rs Outdated Show resolved Hide resolved
zcash_client_sqlite/src/wallet/common.rs Outdated Show resolved Hide resolved
zcash_client_sqlite/src/wallet/common.rs Outdated Show resolved Hide resolved
@nuttycom nuttycom force-pushed the wallet/multi_output_dynamic_min_split branch from b87558f to 01b0d1c Compare November 13, 2024 20:58
@nuttycom nuttycom requested review from daira and str4d November 13, 2024 21:00
@nuttycom
Apply suggestions from code review & Clippy fixes.
00cafa3 
Co-authored by: Jack Grig <jack@electriccoin.co>
Co-authored-by: Daira-Emma Hopwood <daira@jacaranda.org>
@nuttycom nuttycom force-pushed the wallet/multi_output_dynamic_min_split branch from 01b0d1c to 00cafa3 Compare November 13, 2024 21:19
str4d
str4d approved these changes Nov 13, 2024
View reviewed changes
Copy link
Contributor

@str4d str4d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-utACK 00cafa3

@nuttycom nuttycom added this pull request to the merge queue Nov 13, 2024
Merged via the queue into zcash:main with commit be4bc23 Nov 13, 2024
29 checks passed
@nuttycom nuttycom deleted the wallet/multi_output_dynamic_min_split branch November 13, 2024 23:25
@nuttycom nuttycom mentioned this pull request Nov 13, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@str4d str4d str4d approved these changes

@daira daira Awaiting requested review from daira

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nuttycom @daira @str4d