Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zcash_client_sqlite: Fix ambiguity in min checkpoint height query. #1583

Merged
merged 4 commits into from
Oct 22, 2024
Merged

zcash_client_sqlite: Fix ambiguity in min checkpoint height query. #1583

merged 4 commits into from
Oct 22, 2024

Conversation

nuttycom
Copy link
Contributor

No description provided.

str4d
str4d approved these changes Oct 21, 2024
View reviewed changes
Copy link
Contributor

@str4d str4d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK a82a60a after changelog fix

zcash_client_sqlite/CHANGELOG.md Outdated Show resolved Hide resolved
@codecov Codecov
Copy link

codecov bot commented Oct 21, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 61.65%. Comparing base (279479c) to head (69b590a).
Report is 9 commits behind head on hotfix/zcash_client_sqlite-0.12.x.

Files with missing lines Patch % Lines
zcash_client_sqlite/src/wallet.rs 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@                        Coverage Diff                         @@
##           hotfix/zcash_client_sqlite-0.12.x    #1583   +/-   ##
==================================================================
  Coverage                              61.65%   61.65%           
==================================================================
  Files                                    148      148           
  Lines                                  18832    18832           
==================================================================
  Hits                                   11610    11610           
  Misses                                  7222     7222

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@str4d
Copy link
Contributor

str4d commented Oct 22, 2024

Published a82a60a as zcash_client_sqlite 0.12.2.

@nuttycom nuttycom merged commit 048e547 into hotfix/zcash_client_sqlite-0.12.x Oct 22, 2024
27 of 28 checks passed
@nuttycom nuttycom deleted the fix/rewind_checkpoint_id_selection branch October 22, 2024 16:12
daira
daira reviewed Oct 22, 2024
View reviewed changes
Copy link
Contributor

@daira daira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Post-hoc ACK

@nuttycom nuttycom changed the title Fix/rewind checkpoint id selection zcash_client_sqlite: Fix ambiguity in min checkpoint height query. Oct 29, 2024
@nuttycom nuttycom added the bug label Oct 29, 2024
@str4d str4d mentioned this pull request Oct 29, 2024
Closed
@str4d str4d added the C-tracked-bug Category: This is a bug for which we are tracking deployment to apps. label Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daira daira daira left review comments

@str4d str4d str4d approved these changes

Assignees
No one assigned
Labels
bug C-tracked-bug Category: This is a bug for which we are tracking deployment to apps.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nuttycom @str4d @daira