zcash_client_sqlite: Ensure that all shielded change outputs are correctly flagged. #1585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nuttycom
force-pushed
the
debug/is_shielding
branch
3 times, most recently
from
cacbf26
to
0d82e1e
Compare
nuttycom
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1585 +/- ##
==========================================
+ Coverage 56.39% 56.48% +0.08%
==========================================
Files 149 150 +1
Lines 19078 19126 +48
==========================================
+ Hits 10759 10803 +44
- Misses 8319 8323 +4 ☔ View full report in Codecov by Sentry. |
str4d
reviewed
Oct 24, 2024
zcash_client_sqlite/src/wallet/init/migrations/fix_bad_change_flagging.rs
Outdated
Show resolved
Hide resolved
zcash_client_sqlite/src/wallet/init/migrations/fix_bad_change_flagging.rs
Show resolved
Hide resolved
zcash_client_sqlite/src/wallet/init/migrations/fix_bad_change_flagging.rs
Show resolved
Hide resolved
…ash#1571 The update to a shielding transaction causes the information that the output is considered change to be lost. This happens because the scanning process does not have access to any information about the inputs to the transaction, and so it does not recognize the output as change.
…ic migration state.
nuttycom
force-pushed
the
debug/is_shielding
branch
from
0d82e1e
to
4a2a288
Compare
…scind that determination. This is a minimal and correct but incomplete fix for zcash#1571. Additional work to distinguish change outputs is necessary to update existing wallets that have made an incorrect change determination in the past.
…tly flagged when recording sent outputs. Fixes zcash#1571
nuttycom
force-pushed
the
debug/is_shielding
branch
3 times, most recently
from
bca02d5
to
d753090
Compare
|
force-pushed to address review comments then force-pushed to rebase on |
str4d
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1571