zcash_client_sqlite: Verify that the database is for the correct network before (most) migrations. #1596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nuttycom
force-pushed
the
wallet/network_type_check
branch
from
4e30d75
to
6afa7b4
Compare
nuttycom
changed the base branch from
main
to
hotfix/zcash_client_sqlite-0.12.x
…ork before (most) migrations.
nuttycom
force-pushed
the
wallet/network_type_check
branch
from
6afa7b4
to
e24770d
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## hotfix/zcash_client_sqlite-0.12.x #1596 +/- ##
=====================================================================
- Coverage 61.65% 61.64% -0.01%
=====================================================================
Files 148 148
Lines 18832 18868 +36
=====================================================================
+ Hits 11610 11631 +21
- Misses 7222 7237 +15 ☔ View full report in Codecov by Sentry. |
daira
reviewed
Oct 29, 2024
str4d
approved these changes
Oct 29, 2024
nuttycom
merged commit 8733c47
into
zcash:hotfix/zcash_client_sqlite-0.12.x
25 of 27 checks passed
str4d
added
the
C-tracked-bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.