zcash_client_sqlite: Enable constructing WalletDb around references to rusqlite::Connection
#1691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit on its own doesn't expand the public API, as such `WalletDb`s cannot be constructed.
This requires `C: Borrow<rusqlite::Connection>` to ensure that at least `WalletRead` is accessible. It enables construction of the following additional types: - `WalletDb<&rusqlite::Connection, _>` - `WalletDb<&mut rusqlite::Connection, _>`
nuttycom
approved these changes
Jan 30, 2025
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1691 +/- ##
==========================================
- Coverage 52.00% 52.00% -0.01%
==========================================
Files 181 181
Lines 21192 21193 +1
==========================================
Hits 11021 11021
- Misses 10171 10172 +1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables downstream wallets such as Zallet to implement connection pooling, or other strategies to enable multi-threaded
WalletDbaccess.