Code

Action circuit#101

Code

Merged

str4d merged 49 commits intomainzcash/orchard:mainfrom action-circuitzcash/orchard:action-circuitCopy head branch name to clipboardJul 27, 2021

+4,200-1,187

Commits

Commits on Jul 21, 2021

• Implement needed getters and conversions in other modules.

  therealyingtong

  committed
  d16b838

  Copy full SHA for d16b838

• poseidon::pow5t3.rs: Take partial_sbox advice column as input.

  Show description for 3a75f87
  

  therealyingtong

  and

  str4d

  committed
  3a75f87

  Copy full SHA for 3a75f87

• gadget::sinsemilla.rs: Make running sum available at gadget level.

  Show description for 8402c9d
  therealyingtong

  committed
  8402c9d

  Copy full SHA for 8402c9d

• circuit.rs: Define Circuit fields, impl Default for Circuit

  Show description for bdf2d6d
  therealyingtong

  committed
  bdf2d6d

  Copy full SHA for bdf2d6d

• builder.rs: Update ActionInfo::build() to fill in Circuit fields.

  therealyingtong

  committed
  07770a0

  Copy full SHA for 07770a0

• Circuit::configure(): Define Config and configure Circuit.

  Show description for a369004
  therealyingtong

  committed
  a369004

  Copy full SHA for a369004

• Circuit::synthesize(): Load the Sinsemilla generator lookup table.

  therealyingtong

  committed
  23af4d7

  Copy full SHA for 23af4d7

• Circuit::synthesize(): Witness private variables.

  Show description for b64fd5a
  therealyingtong

  committed
  b64fd5a

  Copy full SHA for b64fd5a

• Circuit::synthesize(): Merkle path validity.

  therealyingtong

  committed
  4ba8762

  Copy full SHA for 4ba8762

• Circuit::synthesize(): Value commitment integrity.

  therealyingtong

  committed
  626ee48

  Copy full SHA for 626ee48

• Circuit::synthesize(): Nullifier integrity.

  therealyingtong

  committed
  48b862f

  Copy full SHA for 48b862f

• Circuit::synthesize(): Spend authority.

  therealyingtong

  committed
  f431100

  Copy full SHA for f431100

• sinsemilla::commit_ivk.rs: Helper module for CommitIvk.

  therealyingtong

  committed
  7968c3b

  Copy full SHA for 7968c3b

• commit_ivk.rs: Test canonicity check for different ak, nk values.

  therealyingtong

  committed
  1e35b2b

  Copy full SHA for 1e35b2b

• Circuit::synthesize(): Diversified address integrity.

  therealyingtong

  committed
  f31dd28

  Copy full SHA for f31dd28

• sinsemilla::note_commit.rs: Helper module for NoteCommit.

  therealyingtong

  committed
  3feda97

  Copy full SHA for 3feda97

• note_commit.rs: Test canonicity check for different input values.

  therealyingtong

  committed
  84172e0

  Copy full SHA for 84172e0

• Circuit::synthesize(): Old note commmitment integrity.

  therealyingtong

  committed
  1a1a65a

  Copy full SHA for 1a1a65a

• Circuit::synthesize: New note commitment integrity.

  therealyingtong

  committed
  059af49

  Copy full SHA for 059af49

• circuit.rs: Constrain derived circuit values to equal public inputs.

  therealyingtong

  committed
  6f4b5b0

  Copy full SHA for 6f4b5b0

• circuit.rs: Implement enable spends and enable outputs logic.

  Show description for a10aefc
  therealyingtong

  committed
  a10aefc

  Copy full SHA for a10aefc

• Combine constants fixed columns using assign_advice_from_constant.

  Show description for d803337
  

  therealyingtong

  and

  str4d

  committed
  d803337

  Copy full SHA for d803337

• Optimise location of Poseidon within Action circuit

  Show description for 5e6c8ae
  str4d

  committed
  5e6c8ae

  Copy full SHA for 5e6c8ae

• De-duplicate LookupRangeCheckConfig

  Show description for bf72e30
  

  str4d

  and

  therealyingtong

  committed
  bf72e30

  Copy full SHA for bf72e30

• Optimise layout of witnessed Sinsemilla message pieces

  Show description for 3462d3e
  str4d

  committed
  3462d3e

  Copy full SHA for 3462d3e

• Switch to floor_planner::V1

  Show description for 9d6ae47
  str4d

  committed
  9d6ae47

  Copy full SHA for 9d6ae47

• Use an existing fixed column for Action circuit global constants

  str4d

  committed
  43d1872

  Copy full SHA for 43d1872

Commits on Jul 22, 2021

• Minor refactors, text fixes, and docfixes.

  Show description for 8cf7a68
  

  3 peoplecommitted
  8cf7a68

  Copy full SHA for 8cf7a68

Commits on Jul 23, 2021

• Remove standard PLONK helper.

  Show description for cba0d86
  therealyingtong

  committed
  cba0d86

  Copy full SHA for cba0d86

Commits on Jul 25, 2021

• sinsemilla: Decompose fixed_y_q into binary selector and constant.

  Show description for f6c951d
  therealyingtong

  committed
  f6c951d

  Copy full SHA for f6c951d

• mul::incomplete.rs: Decompose q_mul into binary selectors.

  Show description for f532ece
  therealyingtong

  committed
  f532ece

  Copy full SHA for f532ece

• merkle: Replace l_plus_1 fixed column with q_decompose selector.

  Show description for 29f1850
  therealyingtong

  committed
  29f1850

  Copy full SHA for 29f1850

• merkle: Replace l_plus_1 with l

  Show description for 283b451
  therealyingtong

  committed
  283b451

  Copy full SHA for 283b451

• lookup_range_check: Replace short_lookup_bitshift with selector.

  Show description for 76c7353
  therealyingtong

  committed
  76c7353

  Copy full SHA for 76c7353

• note_commit: Decompose q_canon into two binary selectors.

  Show description for 7af1ae5
  therealyingtong

  committed
  7af1ae5

  Copy full SHA for 7af1ae5

• More small circuit optimisations

  Show description for 092cc38
  

  str4d

  authored and

  therealyingtong

  committed
  092cc38

  Copy full SHA for 092cc38

• Return full running sum [z_0, ..., z_W] from lookup_range_check and decompose_running_sum.

  Show description for 4d1cd26
  therealyingtong

  committed
  4d1cd26

  Copy full SHA for 4d1cd26

• sinsemilla::commit_ivk.rs: Change z14_c -> z13_c

  Show description for 5999d4b
  

  therealyingtong

  and

  str4d

  committed
  5999d4b

  Copy full SHA for 5999d4b

• sinsemilla::commit_ivk: Use 9 advice columns instead of 10

  Show description for d9351df
  

  therealyingtong

  and

  str4d

  committed
  d9351df

  Copy full SHA for d9351df

• sinsemilla::note_commit: Check that g1_g2_prime < 2^130 instead of 2^140.

  Show description for 5b63550
  

  therealyingtong

  and

  str4d

  committed
  5b63550

  Copy full SHA for 5b63550

Commits on Jul 26, 2021

• sinsemilla::commit_ivk: Fix two_pow_5 constraint bug.

  Show description for 57f23d9
  

  therealyingtong

  and

  str4d

  committed
  57f23d9

  Copy full SHA for 57f23d9

• sinsemilla::note_commit: Check canonicity of y(g_d), y(pk_d).

  Show description for 65ccf80
  

  3 peoplecommitted
  65ccf80

  Copy full SHA for 65ccf80

• Use halo2 selector optimizations.

  therealyingtong

  committed
  b3ccd3f

  Copy full SHA for b3ccd3f

Commits on Jul 27, 2021

• sinsemilla::note_commit: Simplify y canonicity check region layout

  Show description for e4a960d
  

  therealyingtong

  and

  str4d

  committed
  e4a960d

  Copy full SHA for e4a960d

• sinsemilla::note_commit: Improve NoteCommit gate layout.

  Show description for 7aa3174
  

  therealyingtong

  and

  str4d

  committed
  7aa3174

  Copy full SHA for 7aa3174

• note_commit::tests: Constrain output of NoteCommit to expected point.

  therealyingtong

  committed
  fa135fe

  Copy full SHA for fa135fe

• commit_ivk::tests: Check value of output ivk against expected ivk.

  therealyingtong

  committed
  664125f

  Copy full SHA for 664125f

• circuit.rs: Minor cleanups and column optimisations.

  Show description for 3f506a0
  

  3 peoplecommitted
  3f506a0

  Copy full SHA for 3f506a0

• Fix y-coordinate recovery in NoteCommit tests

  str4d

  authored
  620e227

  Copy full SHA for 620e227