Add short range check to lookup_range_check util
#132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also introduce a "strict" mode for the full-length lookup, where "true" requires the field element to be within num_words * K bits, whereas "false" does not.
therealyingtong
force-pushed
the
patch-lookup-range-check
branch
from
6450edf to
c43c91b
Compare
therealyingtong
commented
Jun 25, 2021
daira
reviewed
Jun 28, 2021
daira
approved these changes
Jun 28, 2021
Codecov Report
@@ Coverage Diff @@
## main #132 +/- ##
==========================================
+ Coverage 81.44% 83.74% +2.30%
==========================================
Files 38 51 +13
Lines 2430 4299 +1869
==========================================
+ Hits 1979 3600 +1621
- Misses 451 699 +248
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a range check for field elements <=
Kbits, using two lookups in aK-bit table.This also introduces a
strictmode for the full-length lookup (for field elements greater thanKbits) to constrain the final running sum to 0.