Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add orchard::bundle::BatchValidator #338

Merged
merged 3 commits into from
Jun 23, 2022
Merged

Add orchard::bundle::BatchValidator #338

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
35a76f0
Add `orchard::bundle::BatchValidator`
str4d Jun 21, 2022
81626b3
Add batch-verification of proofs to `orchard::bundle::BatchValidator`
str4d Jun 21, 2022
4bed672
Add note about relationship between signatures and proofs
str4d Jun 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/bundle/batch.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,8 @@ impl BatchValidator {
pub fn validate<R: RngCore + CryptoRng>(self, vk: &VerifyingKey, rng: R) -> bool {
if self.signatures.is_empty() {
// An empty batch is always valid, but is not free to run; skip it.
str4d marked this conversation as resolved.
Show resolved Hide resolved
// Note that a transaction has at least a binding signature, so if
// there are no signatures, there are also no proofs.
Copy link
Contributor

@daira daira Jun 24, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this should have more precisely said "A transaction has at least an Orchard binding signature if it has any Orchard components, so if there are no Orchard signatures, there are also no Orchard proofs."

return true;
}

Expand Down