Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor spec to put instantiations in their own section #27

Closed
daira opened this issue Mar 18, 2016 · 5 comments
Closed

Refactor spec to put instantiations in their own section #27

daira opened this issue Mar 18, 2016 · 5 comments

Comments

@daira
Copy link
Collaborator

daira commented Mar 18, 2016

As requested by 7S. This would go just before the "Encoding" section.

@daira daira self-assigned this Mar 18, 2016
@daira daira changed the title Refactor speed to put instantiations in their own section Refactor spec to put instantiations in their own section Mar 18, 2016
@defuse
Copy link
Contributor

defuse commented Apr 12, 2016

+1, this will make interactions between the primitives easier to spot, since they'll all be defined near each other. It will also force us to be explicit about the requirements of things like hSig.

@defuse
Copy link
Contributor

defuse commented Apr 13, 2016

Data point: I probably wouldn't have found the InternalH collision attack if the instantiations were separated. If I had been asked (and given time) to specifically check if that commitment scheme was binding I might have noticed it, but seeing a bunch of important protocol values (rather than an opaque message to be committed to) going into an 128-bit hash was an important motivator to get me thinking about the potential problems.

That said, since we have zcash/zcash#792 I'm still happy about the separation.

@daira
Copy link
Collaborator Author

daira commented Apr 19, 2016

Yes, I'm concerned that the separation in the Zerocash paper might have been a contributing factor to it having been missed by the authors. I want to see how this change looks in practice before committing to making it for the final spec.

@daira
Copy link
Collaborator Author

daira commented May 20, 2016

@defuse and I made a start on this; the work-in-progress is on the https://github.com/zcash/zips/tree/zips27.reorganisation.0 branch.

@daira
Copy link
Collaborator Author

daira commented Sep 4, 2016

Fixed in 2016.0-beta-1.

@daira daira closed this as completed Sep 4, 2016
daira pushed a commit to daira/zips that referenced this issue Nov 8, 2023
This PR adds missing indices over sums. It also fixes and makes improvements to the burn mechanism description.

---------

Co-authored-by: Vivek Arte <46618816+vivek-arte@users.noreply.github.com>
daira pushed a commit to daira/zips that referenced this issue Feb 7, 2024
This PR adds missing indices over sums. It also fixes and makes improvements to the burn mechanism description.

Co-authored-by: Vivek Arte <46618816+vivek-arte@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants