recursive_on_duplicate_key_update doesn't work with non-standard association name

[jacob-carlborg-apoex]

If I have a class structure like this:

class Foo < ActiveRecord::Base
  has_many :items, class_name: "FooItem"
end

class FooItem < ActiveRecord::Base
end

And try to import using recursive_on_duplicate_key_update, like this:

Foo.import(records,
  on_duplicate_key_update: {columns: :all},
  recursive_on_duplicate_key_update: {items: {columns: :all}})

Then activerecord-import won't do an upsert for the association, only for the main records.

The issue is that options[:recursive_on_duplicate_key_update][table_name] returns nil here:

activerecord-import/lib/activerecord-import/import.rb

Line 865 in fca8b82

on_duplicate_key_update: options[:recursive_on_duplicate_key_update][table_name]

The code is looking for a key matching the table name of the association instead of the name of the association itself. The documentation says: "The hash key is the association name".

[jkowens]

Hi @jacob-carlborg-apoex , thanks for reporting this issue. I assume if you do the following it will work?

Foo.import(records,
  on_duplicate_key_update: {columns: :all},
  recursive_on_duplicate_key_update: {foo_items: {columns: :all}})

If you are able to provide a PR to correct this issue that would be appreciated!

[jacob-carlborg-apoex]

Yes, with foo_items it works.

If you are able to provide a PR to correct this issue that would be appreciated!

What's the policy on breaking changes? Changing this would be a breaking change. Should the code try to look for both names or should this be a breaking change?

[jkowens]

Good point, we can go ahead and make a breaking change. We can release in in v2.0 since we loosely follow semver 😅