Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add trilogy adapter #811

Closed

Conversation

zmariscal
Copy link
Contributor

No description provided.

@zmariscal zmariscal force-pushed the feature--add-trilogy-adapter branch from 3a7d28b to 4435c70 Compare August 31, 2023 14:59
@zmariscal zmariscal force-pushed the feature--add-trilogy-adapter branch 8 times, most recently from 6a5e0e2 to 6c93192 Compare September 2, 2023 04:03
@jkowens
Copy link
Collaborator

jkowens commented Sep 4, 2023

This is really cool, I hadn't even heard of trilogy before you opened this PR 😄

@jkowens jkowens mentioned this pull request Sep 4, 2023
@zmariscal zmariscal force-pushed the feature--add-trilogy-adapter branch from 6c93192 to 2322a87 Compare September 4, 2023 22:22
@zmariscal zmariscal force-pushed the feature--add-trilogy-adapter branch from e9efff9 to 1b9ea07 Compare September 15, 2023 00:54
@iggant
Copy link

iggant commented Oct 11, 2023

@zmariscal Is this PR ready to switch from draft? I just tried to switch for trilogy and this is a blocker now for me. Do you need help?

@zmariscal
Copy link
Contributor Author

zmariscal commented Oct 11, 2023

@zmariscal Is this PR ready to switch from draft? I just tried to switch for trilogy and this is a blocker now for me. Do you need help?

@iggant I'm currently waiting for this PR to get merged from a down stream dependency. There's an issue with the trilogy result. 🤞🏼 it can get merged soon.

@zmariscal zmariscal force-pushed the feature--add-trilogy-adapter branch from 0d0f2ea to 433be77 Compare November 9, 2023 22:50
@tdyas
Copy link

tdyas commented Dec 7, 2023

@zmariscal Is this PR ready to switch from draft? I just tried to switch for trilogy and this is a blocker now for me. Do you need help?

@iggant I'm currently waiting for this PR to get merged from a down stream dependency. There's an issue with the trilogy result. 🤞🏼 it can get merged soon.

FYI v14.0.7 of composite_primary_keys has been released with Trilogy support.

@zmariscal
Copy link
Contributor Author

@tdyas thanks for the reminder. I've gotten this working locally, just trying too figure out the CI portion of the PR.

@aovertus
Copy link

aovertus commented Jan 11, 2024

@tdyas thanks for the reminder. I've gotten this working locally, just trying too figure out the CI portion of the PR.

Hi @zmariscal, I believe you are facing the same issue than stated here
trilogy-libraries/activerecord-trilogy-adapter#64 (comment)

We managed to get this working on our project by using the suggested fix from @gstark

Let me know if I can help with this!

Trying to understand how to get the workflow to run but here is what it should looks like : https://github.com/zmariscal/activerecord-import/pull/1/files unless we can allow root to use mysql_native_password

@zmariscal
Copy link
Contributor Author

@tdyas thanks for the reminder. I've gotten this working locally, just trying too figure out the CI portion of the PR.

Hi @zmariscal, I believe you are facing the same issue than stated here trilogy-libraries/activerecord-trilogy-adapter#64 (comment)

We managed to get this working on our project by using the suggested fix from @gstark

Let me know if I can help with this!

Trying to understand how to get the workflow to run but here is what it should looks like : https://github.com/zmariscal/activerecord-import/pull/1/files unless we can allow root to use mysql_native_password

Thanks for the info! I'll give it a try. I was on holiday for awhile so it'll be good to try and get this through soon.

@zmariscal
Copy link
Contributor Author

Closing this PR in favor of this one #825

@zmariscal zmariscal closed this Feb 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants