Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove outdated ruby-debug requirement #861

Merged
merged 2 commits into from
Nov 12, 2024

Conversation

smasato
Copy link
Contributor

@smasato smasato commented Nov 12, 2024

This PR removes an outdated debugging requirement from our test helper and Gemfile. Because Our test matrix in .github/workflows/test.yaml only includes Ruby versions 2.6 and above.

Additionally, JRuby will never meet the condition RUBY_VERSION.to_f < 1.9.

❯ mise exec ruby@jruby-9.4.8.0 -- ruby -e 'puts "#{JRUBY_VERSION}, #{RUBY_VERSION}"'
9.4.8.0, 3.1.4
❯ mise exec ruby@jruby-9.3.15.0 -- ruby -e 'puts "#{JRUBY_VERSION}, #{RUBY_VERSION}"'
9.3.15.0, 2.6.8

@smasato smasato marked this pull request as ready for review November 12, 2024 14:42
@jkowens jkowens merged commit 838951a into zdennis:master Nov 12, 2024
20 checks passed
@smasato smasato deleted the chore/remove-ruby-debug-require branch November 12, 2024 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants