(bugfix): zinit self-update uses current branch #173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vladdoster
force-pushed
the
bugfix/self-update-can-use-any-branch
branch
3 times, most recently
from
96081a4
to
f0f05d6
Compare
|
|
~ bugfix/self-update-can-use-any-branch
ᐳ zi self-update
[self-update] fetching changes for bugfix/self-update-can-use-any-branch
From https://github.com/zdharma-continuum/zinit
* branch bugfix/self-update-can-use-any-branch -> FETCH_HEAD
Already up to date.
[self-update] Compiling Zinit (zcompile)…
[self-update] Reloading Zinit for the current session…
~ bugfix/self-update-can-use-any-branch
ᐳ |
vladdoster
force-pushed
the
bugfix/self-update-can-use-any-branch
branch
2 times, most recently
from
a243057
to
6f671a4
Compare
|
Can you regenerate the docs to get the tests to pass? |
alichtman
requested changes
Feb 3, 2022
vladdoster
force-pushed
the
bugfix/self-update-can-use-any-branch
branch
from
532197d
to
d5dc60c
Compare
|
|
Fix bug in Zinit `self-update` command that used the `main` branch instead of using current branch. Signed-off-by: Vladislav Doster <mvdoster@gmail.com>
vladdoster
force-pushed
the
bugfix/self-update-can-use-any-branch
branch
from
5f03944
to
23c47e1
Compare
Signed-off-by: Vladislav Doster <mvdoster@gmail.com>
Signed-off-by: Vladislav Doster <mvdoster@gmail.com>
alichtman
approved these changes
Apr 18, 2022
yous
reviewed
May 12, 2022
| builtin cd -q "$ZINIT[BIN_DIR]" \ | ||
| && +zinit-message -n "{pre}[self-update]{msg2} fetching latest changes from {msg2}$current_branch$nl{cmd}" \ | ||
| && command git fetch --quiet \ | ||
| && lines=( ${(f)"$(command git log --color --date=short --pretty=format:'%Cgreen%cd %h %Creset%s %Cred%d%Creset || %b' ..FETCH_HEAD)"} ) |
There was a problem hiding this comment.
This line removed --no-pager option, so #177 problem reoccurred. Can this be reverted?
There was a problem hiding this comment.
Yes, there is a nother bug where log output should be on a newline. Preparing PR
There was a problem hiding this comment.
Still it seems that there is no --no-pager in zinit self-update command. When it will be added?
There was a problem hiding this comment.
Please open a new issue instead of commenting on a two year old PR.
|
🎉 This PR is included in version 3.8.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes bug where zinit self-update was hard-coded to use main, even if it was on a different branch.
Signed-off-by: Vladislav Doster mvdoster@gmail.com