-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: autotools support for configure"" ice #345
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vladdoster
changed the title
wip: expand logic for configure"" ice
feat: autotools support for configure"" ice
Jul 18, 2022
wait, somehow my changes got displaced. |
vladdoster
force-pushed
the
maint/update-configure-ice
branch
from
July 18, 2022 02:44
b9f1b5c
to
10258cc
Compare
vladdoster
force-pushed
the
maint/update-configure-ice
branch
from
July 18, 2022 03:53
ce26f40
to
e7fb8e4
Compare
Signed-off-by: Vladislav Doster <mvdoster@gmail.com>
vladdoster
force-pushed
the
maint/update-configure-ice
branch
from
July 18, 2022 04:09
e7fb8e4
to
04b5a2d
Compare
Signed-off-by: Vladislav Doster <mvdoster@gmail.com>
vladdoster
force-pushed
the
maint/update-configure-ice
branch
from
July 18, 2022 04:20
b4a8f22
to
f3e21ca
Compare
Signed-off-by: Vladislav Doster <mvdoster@gmail.com>
Signed-off-by: Vladislav Doster <mvdoster@gmail.com>
Signed-off-by: Vladislav Doster <mvdoster@gmail.com>
Signed-off-by: Vladislav Doster <mvdoster@gmail.com>
Signed-off-by: Vladislav Doster <mvdoster@gmail.com>
Signed-off-by: Vladislav Doster <mvdoster@gmail.com>
Signed-off-by: Vladislav Doster <mvdoster@gmail.com>
Signed-off-by: Vladislav Doster <mvdoster@gmail.com>
Signed-off-by: Vladislav Doster <mvdoster@gmail.com>
Signed-off-by: Vladislav Doster <mvdoster@gmail.com>
Signed-off-by: Vladislav Doster <mvdoster@gmail.com>
Signed-off-by: Vladislav Doster <mvdoster@gmail.com>
TODO
|
Signed-off-by: Vladislav Doster <mvdoster@gmail.com>
Signed-off-by: Vladislav Doster <mvdoster@gmail.com>
7 tasks
Signed-off-by: Vladislav Doster <mvdoster@gmail.com>
Signed-off-by: Vladislav Doster <mvdoster@gmail.com>
Signed-off-by: Vladislav Doster <mvdoster@gmail.com>
Signed-off-by: Vladislav Doster <mvdoster@gmail.com>
vladdoster
force-pushed
the
maint/update-configure-ice
branch
from
July 23, 2022 06:22
7e5d53b
to
db52345
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Expands
configure''
ice capabilities to support Autotools to configure a project.'Additionally, it changes behavior when configuring & making projects with the prefix set to the plugin directory, not
$ZPFX
. This allows zinit to keep track of the binary and properly delete it viazinit delete foo/bar --yes
. An example of this is found here.Motivation and Context
Support popular & common tooling
Related Issue(s)
#334 and #294
Usage examples
How Has This Been Tested?
I need to write a unit test for them
:^(
Types of changes
Checklist:
Signed-off-by: Vladislav Doster mvdoster@gmail.com