Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: autotools support for configure"" ice #345

Closed
wants to merge 20 commits into from

Conversation

vladdoster
Copy link
Member

Description

Expands configure'' ice capabilities to support Autotools to configure a project.'

Additionally, it changes behavior when configuring & making projects with the prefix set to the plugin directory, not $ZPFX. This allows zinit to keep track of the binary and properly delete it via zinit delete foo/bar --yes. An example of this is found here.

Motivation and Context

Support popular & common tooling

Related Issue(s)

#334 and #294

Usage examples

# Example of passing flags when ./configure is ran
zi for \
    configure'#--disable-utf8proc' \
    extract'!' \
    from'gh-r' \
    ver'latest' \
    nocompile \
    as'null' \
    lbin'!**/bin/tmux' \
    make'install' \
  @tmux/tmux

zi for \
    configure'#' \
    nocompile \
    as'null' \
    lbin'!**/bin/stow' \
    make'install' \
  @aspiers/stow

How Has This Been Tested?

I need to write a unit test for them :^(

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: Vladislav Doster mvdoster@gmail.com

@vladdoster
Copy link
Member Author

@psprint

@github-actions github-actions bot added the zinit label Jul 18, 2022
@vladdoster vladdoster changed the title wip: expand logic for configure"" ice feat: autotools support for configure"" ice Jul 18, 2022
@vladdoster
Copy link
Member Author

wait, somehow my changes got displaced.

@vladdoster vladdoster marked this pull request as draft July 18, 2022 00:48
@github-actions github-actions bot added the docs label Jul 18, 2022
Signed-off-by: Vladislav Doster <mvdoster@gmail.com>
Signed-off-by: Vladislav Doster <mvdoster@gmail.com>
@vladdoster vladdoster marked this pull request as ready for review July 18, 2022 04:23
Signed-off-by: Vladislav Doster <mvdoster@gmail.com>
Signed-off-by: Vladislav Doster <mvdoster@gmail.com>
Signed-off-by: Vladislav Doster <mvdoster@gmail.com>
Signed-off-by: Vladislav Doster <mvdoster@gmail.com>
Signed-off-by: Vladislav Doster <mvdoster@gmail.com>
Signed-off-by: Vladislav Doster <mvdoster@gmail.com>
Signed-off-by: Vladislav Doster <mvdoster@gmail.com>
Signed-off-by: Vladislav Doster <mvdoster@gmail.com>
Signed-off-by: Vladislav Doster <mvdoster@gmail.com>
Signed-off-by: Vladislav Doster <mvdoster@gmail.com>
Signed-off-by: Vladislav Doster <mvdoster@gmail.com>
Signed-off-by: Vladislav Doster <mvdoster@gmail.com>
@vladdoster
Copy link
Member Author

TODO

  • Fix broken documentation generation
  • Add comments back to zsh files
  • Write up explanation of the format styling

@vladdoster vladdoster self-assigned this Jul 18, 2022
Signed-off-by: Vladislav Doster <mvdoster@gmail.com>
Signed-off-by: Vladislav Doster <mvdoster@gmail.com>
Signed-off-by: Vladislav Doster <mvdoster@gmail.com>
Signed-off-by: Vladislav Doster <mvdoster@gmail.com>
Signed-off-by: Vladislav Doster <mvdoster@gmail.com>
Signed-off-by: Vladislav Doster <mvdoster@gmail.com>
@vladdoster vladdoster closed this Jul 25, 2022
@vladdoster vladdoster deleted the maint/update-configure-ice branch July 25, 2022 23:01
@psprint psprint mentioned this pull request Jan 12, 2023
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant