Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: creinstall cmd --quiet & --force flags #520

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

vladdoster
Copy link
Member

Description

  • -q/--quiet && -f/--force options now work
  • update creinstall zsh completion with --quiet, --force, and --help flags
  • move creinstall cmd logic to dedicated function

Related Issue(s)

Closes #518

Motivation and Context

Usage examples

Screenshot 2023-05-14 at 10 54 12

How Has This Been Tested?

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • Bug fix (non-breaking change which fixes an issue)
  • Documentation change
  • New feature (non-breaking change which adds functionality)

Checklist:

  • All new and existing tests passed.
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.

Signed-off-by: Vladislav Doster <mvdoster@gmail.com>
@alichtman
Copy link
Member

alichtman commented May 20, 2023

image
Shouldn't --quiet silence the output shown here? I was expecting it to remove the Installed X completions line

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug]: zinit creinstall -Q ... or -q is not quiet
2 participants