Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A new ice build'' that's a shorthand for: null configure'' make'' #548

Closed
wants to merge 2 commits into from

Conversation

psprint
Copy link
Contributor

@psprint psprint commented Jul 28, 2023

Description

I think that the PR is important so I'm refreshing it (old: #458).

After the configure'' ice has been added the building of programs from sources became simpler. The new ice build'' is one step further – zinit null configure make for … will be equivalent of zinit build for …. The new ice is just a "pull-in" ice, as all that it does is to pull-in the other 3 ices. null ice pulling can be blocked with nonull. Parameters given to build'' are passed to the underlying make'' ice.

Motivation and Context

The motivation is to type-less and to have a clear way of compiling apps with zinit. Withbuild'' ice there's a single method of building all kinds of software, from autotools to meson. I also add a test case and update README.md.

Usage examples

zi id-as'slang' extract'!' build \
            for http://www.jedsoft.org/snapshots/slang-pre2.3.4-5.tar.gz

zi id-as from"gitlab.matrix.org" build \
                for matrix-org/olm

zinit id-as build"install install-doc-man" \
              atclone="asciidoctor -b manpage doc/*.adoc" \
              atpull"%atclone" \
                  for jonas/tig`

zinit id-as build for universal-ctags/ctags

How Has This Been Tested?

I've been using the ice with no problems for about of 8 months with no problems, for a variety of software, like the above examples.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • Bug fix (non-breaking change which fixes an issue)
  • Documentation change
  • New feature (non-breaking change which adds functionality)

Checklist:

  • All new and existing tests passed.
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.

@psprint
Copy link
Contributor Author

psprint commented Jul 29, 2023

@vladdoster @pschmitt ping

@psprint
Copy link
Contributor Author

psprint commented Aug 19, 2023

@vladdoster: ping. I've revived the patch and expect a merge

@psprint
Copy link
Contributor Author

psprint commented Aug 21, 2023

@vladdoster: Why this still has not been merged?

@vladdoster
Copy link
Member

Closing in favor of PR feat: configure, make, cmake, and build ices (#613).

@vladdoster vladdoster closed this Feb 1, 2024
@zdharma-continuum zdharma-continuum locked as resolved and limited conversation to collaborators Feb 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants