Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to set custom autocomplete values on password mdui-textfield #356

Merged
merged 3 commits into from
Oct 23, 2024

Conversation

swagliquido
Copy link
Contributor

@swagliquido swagliquido commented Oct 22, 2024

Currently if I use this element, autocomplete gets turned off:
<mdui-text-field type="password" autocomplete="new-password"></mdui-text-field>

The pull request removes the limitation. I tested it and now it works for me. I don't know why there was this check in the code:

autocomplete=${ifDefined(
  this.type === 'password' ? 'off' : this.autocomplete,
)}

I just changed it to this:
autocomplete=${this.autocomplete}

@swagliquido swagliquido changed the title Allows to set custom autocomplete values on password mdui-textfield Allow to set custom autocomplete values on password mdui-textfield Oct 22, 2024
@zdhxiong
Copy link
Owner

You are right, but please revert the unrelated formatting changes.

@swagliquido
Copy link
Contributor Author

You are right, but please revert the unrelated formatting changes.

Done

@zdhxiong zdhxiong merged commit 81a1b77 into zdhxiong:v2 Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants