Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Find in page: Ctrl+Enter should toggle Highlight All mode #1467

Closed
ratijas opened this issue Feb 26, 2023 · 2 comments · Fixed by #1476
Closed

Find in page: Ctrl+Enter should toggle Highlight All mode #1467

ratijas opened this issue Feb 26, 2023 · 2 comments · Fixed by #1476
Labels
scope/ui status/done type/enhancement
Milestone
0.7.0

Comments

@ratijas
Copy link
Contributor

ratijas commented Feb 26, 2023

Currently, focusing the "Find in page" search field and pressing Ctrl+Enter key combination does nothing special, it's just treated as an Enter and finds next match.

Expected behavior

In Firefox, Ctrl+Enter in the "Find in page" field toggles Highlight All mode, which is quite convenient.

Version

Zeal: 0.6.1
Qt: 5.15.8
@ratijas
Copy link
Contributor Author

ratijas commented Feb 26, 2023

By the way, pressing Alt+C does toggle the Match Case mode, which is good and consistent with others.

@ratijas
Copy link
Contributor Author

ratijas commented Mar 21, 2023

Turns out, Match Case button reacts to Alt+C thanks to its mnemonic shortcut: "Mat&ch Case". Highlight can also be toggled with Alt+L.

ratijas added a commit to ratijas/zeal that referenced this issue Mar 21, 2023
@ratijas
feat(browser): Implement Ctrl+Enter to toggle "Highlight All" search …
280b24f 
…option

Fixes zealdocs#1467
@ratijas ratijas mentioned this issue Mar 21, 2023
Merged
trollixx pushed a commit that referenced this issue Apr 5, 2023
@ratijas
feat(browser): add Ctrl+Enter shortcut for Highlight All option (#1476)
80d45f7 
Fixes #1467.
@trollixx trollixx added this to the 0.7.0 milestone Apr 5, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Oct 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
scope/ui status/done type/enhancement
Milestone
0.7.0
Development

Successfully merging a pull request may close this issue.

feat(browser): add Ctrl+Enter shortcut for Highlight All option ratijas/zeal
2 participants
@trollixx @ratijas