Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Zeal 0.3.0 remove docset not actually working #621

Closed
kailiu42 opened this issue Oct 9, 2016 · 4 comments
Closed

Zeal 0.3.0 remove docset not actually working #621

kailiu42 opened this issue Oct 9, 2016 · 4 comments
Assignees
@jmymay
Labels
platform/windows scope/ui/docset-manager status/done type/defect
Milestone
0.3.1

Comments

@kailiu42
Copy link

kailiu42 commented Oct 9, 2016

In 0.3.0 when remove a docset int the docset manager UI, it gets removed from the list and the main UI. However files on the disk remain untouched and after restart Zeal the deleted docset just reappear in the list.

My system is Win10, tried portable and non-portable version.
jmymay added a commit to jmymay/zeal that referenced this issue Oct 9, 2016
@jmymay
ui: Fix docset removing on Windows (fixes zealdocs#621)
f048110 
Docsets need to be removed from registry first, to avoid rename()
failing when files are in use.
jmymay added a commit to jmymay/zeal that referenced this issue Oct 9, 2016
@jmymay
ui: Fix docset removing on Windows (fixes zealdocs#621)
158cb50 
Docsets need to be removed from registry first, to avoid rename()
failing when files are in use.
jmymay added a commit to jmymay/zeal that referenced this issue Oct 9, 2016
@jmymay
ui: Fix docset removing on Windows (fixes zealdocs#621)
334e480 
Docsets need to be removed from registry first, to avoid rename()
failing when files are in use.
jmymay added a commit to jmymay/zeal that referenced this issue Oct 9, 2016
@jmymay
ui: Fix docset removing on Windows (fixes zealdocs#621)
b17c4fb 
Docsets need to be removed from registry first, to avoid rename()
failing when files are in use.
jmymay added a commit to jmymay/zeal that referenced this issue Oct 9, 2016
@jmymay
ui: Fix docset removal on Windows (fixes zealdocs#621)
1b5e0f4 
Docsets need to be removed from registry first, to avoid rename()
failing when files are in use.
@trollixx trollixx added this to the 0.3.1 milestone Oct 9, 2016
@kailiu42
Copy link
Author

kailiu42 commented Oct 10, 2016 •
edited
Loading

Just compiled 0.3.1 by my own and above changes caused a new problem. After selected a docset in the manager UI and clicked the remove button, I got a popup dialog says "Remove 0 docset(s)?". Clicking Yes does nothing, just return to the manager UI.

Edit: just tried further, no matter how many docsets I select and remove, the popup always confirms about removing 0 docset. And click Yes never lead to a successful remove of the docset(s). I'm on portable version.

@trollixx
Copy link
Member

It's because I forgot to commit changes to the docsetsdialog.ui in #625. Please consider v0.3.1 not released yet :)

@trollixx
Copy link
Member

@Kraml, should be fixed now in the "new" 0.3.1. A stupid mistake :(

@lock
Copy link

lock bot commented Sep 16, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related requests.

@lock lock bot locked and limited conversation to collaborators Sep 16, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jmymay jmymay

Labels
platform/windows scope/ui/docset-manager status/done type/defect
Milestone
0.3.1
Development

No branches or pull requests
3 participants
@jmymay @kailiu42 @trollixx