Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

review registerCycle usage to speedup grid registration #388

Closed
vdelendik opened this issue May 17, 2024 · 2 comments
Closed

review registerCycle usage to speedup grid registration #388

vdelendik opened this issue May 17, 2024 · 2 comments
Labels
enhancement New feature or request
Milestone
2.1.7

Comments

@vdelendik
Copy link
Contributor

we increased registerCycle to 300000 but as result increased default registration upto 5 min.
Let's review grid registration logic to make it asap for the first start and reuse registerCycle only for restarts...
@vdelendik vdelendik added the enhancement New feature or request label May 17, 2024
@vdelendik vdelendik added this to the 2.2 milestone May 17, 2024
@vdelendik vdelendik modified the milestones: 2.2, 2.1.7 Aug 15, 2024
vdelendik pushed a commit that referenced this issue Aug 15, 2024
#388: synched timeouts with mcloud-grid
48d9046
@vdelendik
Copy link
Contributor Author

vdelendik commented Aug 15, 2024 •
edited
Loading

done. @dhreben you can test using appium 2.1.7-beta3.
to test:

  1. stop appium container
  2. track that in 10-15 seconds this appium node will be marked as stale (in mcloud-grid logs)
  3. track that sfater staling in ~5000ms node will be removed from the grid
    -> unreachable device is removed almost asap (earlier it was in the list for 60+ seconds)

vdelendik pushed a commit that referenced this issue Aug 16, 2024
#388: decereased unregister node timeout from 5 to 3sec to speedup cl…
9ef4ce5 
…eanup
vdelendik added a commit that referenced this issue Aug 16, 2024
@vdelendik
Merge pull request #420 from zebrunner/#388
d487462 
#388
@dhreben
Copy link
Contributor

dhreben commented Aug 16, 2024

Verified.

12:28:28.153 INFO [DefaultRemoteProxy.onEvent] - Marking the node http://demo.zebrunner.farm:7631 as down: cannot reach the node for 3 tries
12:28:33.155 INFO [DefaultRemoteProxy.onEvent] - Unregistering the node http://demo.zebrunner.farm:7631 because it's been down for 5002 milliseconds
12:28:33.155 WARN [DefaultGridRegistry.removeIfPresent] - Cleaning up stale test sessions on the unregistered node http://demo.zebrunner.farm:7631

Also device has Failed to connect status on mcloud/grid/console

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
Device Farm (MCloud)
Status: Done
Milestone
2.1.7
Development

No branches or pull requests
2 participants
@vdelendik @dhreben