Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hide model name column for devices by default #451

Closed
vdelendik opened this issue May 14, 2022 · 6 comments
Closed

hide model name column for devices by default #451

vdelendik opened this issue May 14, 2022 · 6 comments
Assignees
@ignacionar
Labels
enhancement
Milestone
2.6.4

Comments

@vdelendik
Copy link
Contributor

we replaced model by our custom device name. let's return original model name so we provide mare valuable information to users to analyze. Using model it is much faster to look for actual technical details etc
@vdelendik vdelendik added this to the 2.2 milestone May 14, 2022
vdelendik added a commit that referenced this issue May 14, 2022
@vdelendik
#451: restored original model/brand name for android devices
93a385c
@vdelendik
Copy link
Contributor Author

done. instead duplicating model and product we keep our devicename for Product column and model/brand name for Modal.
the most important part of testing - execution of mobile web tests vs concrete device using deviceName=Nokia_3 capability for example.

@vdelendik vdelendik modified the milestones: 2.2, 2.3 May 14, 2022
@vdelendik
Copy link
Contributor Author

change is not so easy so reverting and assigning to the next milestone

@vdelendik vdelendik reopened this May 14, 2022
vdelendik added a commit that referenced this issue May 14, 2022
@vdelendik
#451: reverting product/model name updates
7f5b0fb
@vdelendik vdelendik modified the milestones: 2.3, 2.4 Aug 1, 2022
@vdelendik vdelendik modified the milestones: 2.4, 2.5 Dec 12, 2022
@vdelendik vdelendik modified the milestones: 2.6, 2.7 Nov 4, 2023
@vdelendik vdelendik modified the milestones: 2.7, 2.6.4 Feb 7, 2024
@vdelendik vdelendik changed the title restore original model name for devices hide model name column for devices by default Feb 7, 2024
@vdelendik
Copy link
Contributor Author

@ignacionar, instead of refactoring all kind of shell scripts and registration logic let's just make this column hidden by default. Make sure it becomes hidden after reset customization

ignacionar pushed a commit to ignacionar/stf that referenced this issue Feb 7, 2024
zebrunner#451 Hidel model column by default
b0087fb
vdelendik added a commit that referenced this issue Feb 7, 2024
@vdelendik
Merge pull request #884 from ignacionar/#451
c28770e 
#451 Hide model column by default
@ignacionar
Copy link
Collaborator

Done: #884

@vdelendik
Copy link
Contributor Author

vdelendik commented Mar 8, 2024 •
edited
Loading

all good. to test make sure to click reset -> Model column is unchecked by default

@dhreben
Copy link
Contributor

dhreben commented Mar 12, 2024

Verified.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ignacionar ignacionar

Labels
enhancement
Projects
Device Farm (MCloud)
Archived in project
Milestone
2.6.4
Development

No branches or pull requests
3 participants
@vdelendik @dhreben @ignacionar