Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

invalid condition of 1st time device usage and as result width/height can't be detected #971

Closed
vdelendik opened this issue May 30, 2024 · 2 comments
Closed

invalid condition of 1st time device usage and as result width/height can't be detected #971

vdelendik opened this issue May 30, 2024 · 2 comments
Assignees
@ignacionar
Labels
bug
Milestone
2.7.1

Comments

@vdelendik
Copy link
Contributor

in case of iOS 17 where we start wda independently via xcode we'va found a problem with width/height detection.
it seems like we have a version but don't have sizes and as result this condition is broken:

stf/lib/units/ios-device/plugins/group.js

Line 75 in eae9a9a

// No device version = First device session

image
@vdelendik vdelendik added the bug label May 30, 2024
@vdelendik vdelendik added this to the 2.7.1 milestone May 30, 2024
ignacionar pushed a commit to ignacionar/stf that referenced this issue May 30, 2024
zebrunner#971 change condition on first session
7333ee2
dhreben added a commit that referenced this issue Jun 6, 2024
@dhreben
Merge pull request #972 from ignacionar/#971
36796c3 
#971 change condition on first session
@dhreben
Copy link
Contributor

dhreben commented Jun 6, 2024 •
edited
Loading

Implemented for testing:

  • public.ecr.aws/zebrunner/stf:2.7.1-beta3
  • public.ecr.aws/zebrunner/mcloud-device:2.7.1-beta3

@dhreben dhreben closed this as completed Jun 6, 2024
@dhreben
Copy link
Contributor

dhreben commented Jun 6, 2024

Fixed
Screenshot 2024-06-06 at 16 28 20

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ignacionar ignacionar

Labels
bug
Projects
Device Farm (MCloud)
Archived in project
Milestone
2.7.1
Development

No branches or pull requests
3 participants
@vdelendik @dhreben @ignacionar