Integrate with the Buildx Dockerfile debugger #27
Conversation
Buildx implements DAP to allow users to debug Dockerfile builds. Signed-off-by: Remy Suen <remy.suen@docker.com>
Signed-off-by: Remy Suen <remy.suen@docker.com>
|
I made a small change to note that the minimal version of Buildx that is required is v0.28.0. Let me know if there is anything else that may be unclear or needs further clarification in the documentation. And here's a video that shows the feature in action to help with testing and validating this pull request. 2025-10-08-zed-dockerfile-debugging-720p.mov |
|
Thanks for this and sorry for the delay in review! I'll try to get this in soon, hopefully tomorrow, latest next week. |
Signed-off-by: Remy Suen <remy.suen@docker.com>
1. stopOnEntry can now be set in the configuration to immediately suspend the debugger on the first line it tries to execute. 2. args can be defined in the configuration and they will be passed to the build command. For example, you may use --build-arg ARG_VAR=otherValue to change the value of an ARG instruction at build-time. 3. Improved the sample in README.md to include a small description about all the attributes that can be set. Signed-off-by: Remy Suen <remy.suen@docker.com>
The default values that are defined in the JSON schema are not actually injected into the configuration at runtime so we need to inject it ourselves. Signed-off-by: Remy Suen <remy.suen@docker.com>
@MrSubidubi No problem and thanks for the info! I know the Zed team's busy so I appreciate you making the time to slot this into your busy schedule. 👍 |
Technically, request is not a required attribute and we could just force the value to be "launch". However, it feels better to make it a required value that must be defined so that the user clearly understands that only launched sessions are supported and that attached sessions are unsupported. Signed-off-by: Remy Suen <remy.suen@docker.com>
MrSubidubi
left a comment
MrSubidubi
left a comment
There was a problem hiding this comment.
Works very well for me, thank you so much!
And also, thanks for updating the README accordingly! Much appreciated.
This PR bumps the version of the dockerfile extension to 0.1.0. Includes: - zed-extensions/dockerfile#25 - zed-extensions/dockerfile#27
Thanks for reviewing this, @MrSubidubi! Glad to hear that the testing went smoothly for you. Have a great week! :) |
|
Thanks, you too! |
2 participants
Buildx implements DAP to allow users to debug Dockerfile builds.