Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Language server binary is not executable #19

Closed
424ever opened this issue Aug 16, 2024 · 0 comments · Fixed by #20
Closed

Language server binary is not executable #19

424ever opened this issue Aug 16, 2024 · 0 comments · Fixed by #20

Comments

@424ever
Copy link
Contributor

424ever commented Aug 16, 2024

Only tested on Linux.

From the logs the issue seems to be that ~/.local/share/zed/extensions/work/kotlin/kotlin-language-server-1.3.12/server/bin/kotlin-language-server isn't executable.

I did some digging and the cause seems to be zed-industries/zed#13869, because smol::fs::File::create by default sets the file's permissions to -rw-r--r--, whereas unzip carries over the file's permissions from the zip archive.

maxdeviant pushed a commit that referenced this issue Aug 23, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Resolves #19
Draft because I'm unsure this repo is the correct place to fix the
issue. Maybe it should be `zed::download_file`'s job to carry over file
permissions when extracting a zip file.

Note that `zed::make_file_executable` is a noop on non-unix platforms,
so it shouldn't be an issue to call it here.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant