Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Discord presence extension #1217

Merged

Conversation

xhyrom
Copy link
Contributor

@xhyrom xhyrom commented Aug 7, 2024

Closes #499

GitHub repository: https://github.com/xhyrom/zed-discord-presence

It's done by LSP right now but once Zed gets normal extension support i'll rewrite it 👍

Copy link

cla-bot bot commented Aug 7, 2024

We require contributors to sign our Contributor License Agreement, and we don't have @xhyrom on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'.

@xhyrom
Copy link
Contributor Author

xhyrom commented Aug 7, 2024

@cla-bot check

Copy link

cla-bot bot commented Aug 7, 2024

We require contributors to sign our Contributor License Agreement, and we don't have @xhyrom on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'.

Copy link

cla-bot bot commented Aug 7, 2024

The cla-bot has been summoned, and re-checked this pull request!

@xhyrom
Copy link
Contributor Author

xhyrom commented Aug 7, 2024

@cla-bot check

@cla-bot cla-bot bot added the cla-signed label Aug 7, 2024
Copy link

cla-bot bot commented Aug 7, 2024

The cla-bot has been summoned, and re-checked this pull request!

@maxdeviant maxdeviant changed the title add discord presence extension Add Discord presence extension Aug 23, 2024
@maxdeviant
Copy link
Member

@xhyrom Before we go accepting this into the registry, could you say a bit more about how the Discord auth works for the Discord rich presence language server?

@xhyrom
Copy link
Contributor Author

xhyrom commented Aug 23, 2024

@xhyrom Before we go accepting this into the registry, could you say a bit more about how the Discord auth works for the Discord rich presence language server?

I'm using https://github.com/vionya/discord-rich-presence which is a pretty nice library for it. You can check the code if you want. It just searches for discord ipc path and connects to it.

@maxdeviant
Copy link
Member

@xhyrom Before we go accepting this into the registry, could you say a bit more about how the Discord auth works for the Discord rich presence language server?

I'm using https://github.com/vionya/discord-rich-presence which is a pretty nice library for it. You can check the code if you want. It just searches for discord ipc path and connects to it.

I see, so it's just communicating with the local Discord instance over IPC?

I think that assuages my concerns around security 🙂

@maxdeviant
Copy link
Member

@xhyrom Could you change the extension ID to be discord-presence instead of discord_presence? We don't allow underscores in extension IDs.

@xhyrom
Copy link
Contributor Author

xhyrom commented Aug 24, 2024

@xhyrom Could you change the extension ID to be discord-presence instead of discord_presence? We don't allow underscores in extension IDs.

fixed

@maxdeviant
Copy link
Member

@xhyrom Could you change the extension ID to be discord-presence instead of discord_presence? We don't allow underscores in extension IDs.

fixed

Can you update here as well? https://github.com/zed-industries/extensions/pull/1217/files#diff-724e5177a66640ebdc9d051879ac354bbfd595c1b4d039bab887600964bb2023R231

Unfortunately GitHub won't let me push to this branch since the PR was created from a GitHub organization 😢

@xhyrom
Copy link
Contributor Author

xhyrom commented Aug 26, 2024

done :D

@maxdeviant
Copy link
Member

done :D

@xhyrom I think we're almost there! Looks like the two version numbers don't align right now.

@xhyrom
Copy link
Contributor Author

xhyrom commented Aug 26, 2024

done :D

@xhyrom I think we're almost there! Looks like the two version numbers don't align right now.

You're right, sorry 😅😃

Copy link
Member

@maxdeviant maxdeviant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@maxdeviant maxdeviant merged commit 9303545 into zed-industries:main Aug 26, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add discord rich presence
2 participants