Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CSpell extension #1864

Merged
merged 6 commits into from
Jan 5, 2025
Merged

Add CSpell extension #1864

merged 6 commits into from
Jan 5, 2025

Conversation

mantou132
Copy link
Contributor

@mantou132 mantou132 commented Jan 5, 2025

@cla-bot cla-bot bot added the cla-signed label Jan 5, 2025
@mantou132 mantou132 force-pushed the main branch 3 times, most recently from ee62bc9 to ba787c6 Compare January 5, 2025 07:50
Copy link
Member

@maxdeviant maxdeviant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@maxdeviant maxdeviant merged commit 6693379 into zed-industries:main Jan 5, 2025
2 checks passed
@notpeter
Copy link
Member

notpeter commented Jan 6, 2025

@mantou132 I see this uses cspell-lsp from npm (which you uploaded) but I don't see a corresponding source repository anywhere.

  1. I assume this is a fork of vlabo/cspell-lsp or streetsidesoftware/vscode-spell-checker. Do you intend to publish sources for the package you are distributing on NPM?

  2. The license in your package.json (and thus on NPM) is incorrectly listed as ISC while cspell-lsp-1.0.1.tgz contains a GPLv3 LICENSE which matches the repos above.

@mantou132
Copy link
Contributor Author

@notpeter yes. fork of vlabo/cspell-lsp https://github.com/mantou132/cspell-lsp

I updated the license in package.json to maintain the same as the original program

@notpeter notpeter mentioned this pull request Jan 7, 2025
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants