Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add benich-theme extension #2014

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

lucastomic
Copy link

Benich theme is a dark theme

Copy link

cla-bot bot commented Feb 8, 2025

We require contributors to sign our Contributor License Agreement, and we don't have @lucastomic on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'.

@zed-industries-bot
Copy link

Warnings
⚠️

This PR doesn't include changes to extensions.toml.

If you are creating a new extension, add a new entry to it.

If you are updating an existing extension, update the version number in the corresponding entry.

Generated by 🚫 dangerJS against 8a96fec

@notpeter
Copy link
Member

notpeter commented Feb 10, 2025

Hi!

A couple things:

  1. You need to sign the CLA and follow the instructions in the comment above to recheck the PR
  2. You need to add your theme/version to extensions.toml (this repo)
  3. You need to sort .gitmodules, either manually or with pnpm run sort-extensions (this repo)
    1. Your theme json needs to be in a subdirectory called themes (your repo)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants